Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchControl: Improve RTL support #57406

Closed
mirka opened this issue Dec 27, 2023 · 2 comments
Closed

SearchControl: Improve RTL support #57406

mirka opened this issue Dec 27, 2023 · 2 comments
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Comments

@mirka
Copy link
Member

mirka commented Dec 27, 2023 •
edited
Loading

The search icon and the close button positioning should flip accordingly in RTL mode.

Here is a reference design from Google in Arabic:

A Google search field in RTL mode, where the close button is on the left and the search icon is on the right

This should be addressed after we swap out the implementation in #56524.
@mirka mirka added [Type] Enhancement A suggestion for improvement. Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Components /packages/components labels Dec 27, 2023
@youknowriad
Copy link
Contributor

Screenshot 2024-01-01 at 4 14 49 PM

This actually looks great to me, it's the google version that looks weird for me.

@mirka
Copy link
Member Author

mirka commented Jan 2, 2024

You're right, sorry. I was mid-refactor in a unification effort and was probably looking at a different implementation 😅

@mirka mirka closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@youknowriad @mirka