Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadow: add shadow in block settings (site editor) #57101

Closed
madhusudhand opened this issue Dec 15, 2023 · 1 comment · Fixed by #57654
Closed

Shadow: add shadow in block settings (site editor) #57101

madhusudhand opened this issue Dec 15, 2023 · 1 comment · Fixed by #57654
Assignees
@vcanales @madhusudhand
Labels
[Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.

Comments

@madhusudhand
Copy link
Member

What problem does this address?

Add the shadow component in block settings in the site editor. With current implementation, it is only possible to choose/add shadows to blocks only from the global styles.

Adding shadow in the site editor enables specific blocks to have shadows.

What is your proposed solution?

Proposed UI

image

Parent issue

#44651
@madhusudhand madhusudhand added the [Type] Enhancement A suggestion for improvement. label Dec 15, 2023
@madhusudhand madhusudhand changed the title Shadow: add ability to apply shadow to a block from block settings (in site editor) Shadow: add shadow in block settings (site editor) Dec 15, 2023
@madhusudhand madhusudhand mentioned this issue Dec 15, 2023
Closed
7 tasks
@jordesign jordesign added the [Feature] Blocks Overall functionality of blocks label Dec 17, 2023
@caseymilne
Copy link

That looks good, looking forward to be able to declare it through block/supports.

@vcanales vcanales linked a pull request Jan 10, 2024 that will close this issue
Add effects/box shadow tools to block inspector #57654
Merged
2 tasks
@vcanales vcanales self-assigned this Jan 10, 2024
@annezazu annezazu moved this to 📥 Todo in WordPress 6.5 Editor Tasks Jan 11, 2024
@madhusudhand madhusudhand self-assigned this Jan 19, 2024
@bgardner bgardner mentioned this issue Jan 21, 2024
Closed
@mikachan mikachan moved this from 📥 Todo to 🔎 Needs Review in WordPress 6.5 Editor Tasks Jan 23, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.5 Editor Tasks Jan 23, 2024
@madhusudhand madhusudhand mentioned this issue Jan 26, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vcanales vcanales

@madhusudhand madhusudhand

Labels
[Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Projects
No open projects
WordPress 6.5 Editor Tasks
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add effects/box shadow tools to block inspector WordPress/gutenberg
4 participants
@vcanales @jordesign @madhusudhand @caseymilne