Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global Styles: Always show inherited values in the inspector if we know them #55951

Closed
michalczaplinski opened this issue Nov 7, 2023 · 2 comments
Closed

Global Styles: Always show inherited values in the inspector if we know them #55951

michalczaplinski opened this issue Nov 7, 2023 · 2 comments
Assignees
@michalczaplinski
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@michalczaplinski
Copy link
Contributor

michalczaplinski commented Nov 7, 2023 •
edited
Loading

Parent issue: #49278

if a particular style is inherited (e.g. from Global Styles) the control displays that value, and the label has a purple accent denoting the global context.

The control cannot be removed because the inherited value will be used if there's no local setting.
@michalczaplinski michalczaplinski mentioned this issue Nov 7, 2023
Open
4 tasks
@michalczaplinski michalczaplinski self-assigned this Nov 7, 2023
@michalczaplinski michalczaplinski added [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Nov 7, 2023
@michalczaplinski michalczaplinski changed the title Always show inherited values in the inspector if we know them. Global Styles: Always show inherited values in the inspector if we know them Nov 7, 2023
@michalczaplinski michalczaplinski mentioned this issue Nov 7, 2023
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 7, 2023
@jameskoster
Copy link
Contributor

Should we close this? It's essentially a duplicate of #37752 which was re-opened recently.

@michalczaplinski
Copy link
Contributor Author

Makes sense @jameskoster !

Closing this one in favour of #37752

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michalczaplinski michalczaplinski

Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Try: Indicate when text color in post editor is inherited from Global Styles WordPress/gutenberg
2 participants
@jameskoster @michalczaplinski