Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Book icon button in the navigator doesn't show any pressed style #52594

Open
afercia opened this issue Jul 13, 2023 · 3 comments
Open

Style Book icon button in the navigator doesn't show any pressed style #52594

afercia opened this issue Jul 13, 2023 · 3 comments
Labels
Needs Design Feedback Needs general design feedback. [Package] Edit Site /packages/edit-site [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jul 13, 2023

Description

The 'Stye book' icon button is a 'toggle button' as in: can be activated and it stays in a 'pressed' state until it is deactivated. When activated, the editor shows the Style Book.

The 'pressed' state must be communicated visually and semantically.
Semantically: the button gets an aria-pressed="true" attribute.
Visually: it should show a pressed style.

In the Editor settings panel, the pressed style works well: the button gets a dark background against the white nackground of the sidebar. Screenshot: on the left: non-pressed, on the right: pressed.

Screenshot 2023-07-13 at 13 01 38

However, in the Navigator panel, the pressed style doesn't work simply because the background of the panel is dark and the icon button is adrl also when non-pressed. There is no visual difference between the two states.
Screenshot: on the left: non-pressed, on the right: pressed.

Screenshot 2023-07-13 at 13 02 16

As such, sighted users can't determine the state of the button, which is a less than ideal UI.

Step-by-step reproduction instructions

  • Go to the Site Editor > Design > Styles.
  • Click the Style Book icon button.
  • Observe there's no visual difference when the button is pressed and non-pressed.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. [Package] Edit Site /packages/edit-site labels Jul 13, 2023
@t-hamano
Copy link
Contributor

t-hamano commented Aug 8, 2023

I proposed in #53430 a comprehensive solution approach that includes this issue.

@afercia
Copy link
Contributor Author

afercia commented Aug 23, 2023

@t-hamano I don't know enough about the Theme component to understand how it works but your proposal in #53430 sounds brilliant ❤️

@t-hamano
Copy link
Contributor

For additional information, the design system proposed in #53612 may provide a more comprehensive solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Package] Edit Site /packages/edit-site [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants