DropdownMenu v2: align component to shared styles and theme variables #50971
Labels
[Feature] UI Components
Impacts or related to the UI component system
[Package] Components
/packages/components
[Type] Enhancement
A suggestion for improvement.
Update: the main task behind this issue is still relevant, although the details may be out of date.
Overall list of things that need to be considered:
Currently, there are some values applied in the styles to the new
DropdownMenu
component that don't correspond (or can't be found) in the shared "design" config of the components package.We should either update the new
DropdownMenu
component to use existing shared values (mostly colors), or discuss whether some of the component's styles should be extracted and added to the shared config.Additionally, we should ideally update every color variable from being a hardcoded value (even if shared), to being a theme variable.
COLORS.ui.background
COLORS.gray[ 900 ]
opacity: 0.5
opacity: 0.6
COLORS.ui.theme
(although it may change toCOLORS.gray[ '100' ]
COLORS.gray[ 700 ]
COLORS.gray[ 400 ]
box-shadow: 0.1px 4px 16.4px -0.5px rgba( 0, 0, 0, 0.1 ), 0px 5.5px 7.8px -0.3px rgba( 0, 0, 0, 0.1 ), 0px 2.7px 3.8px -0.2px rgba( 0, 0, 0, 0.1 ), 0px 0.7px 1px rgba( 0, 0, 0, 0.1 );
Elevation
component instead, or at least add a shared box shadow style that all components can useThe text was updated successfully, but these errors were encountered: