Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block mover drag handle cursor style should be grab #50789

Closed
afercia opened this issue May 19, 2023 · 1 comment
Closed

Block mover drag handle cursor style should be grab #50789

afercia opened this issue May 19, 2023 · 1 comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@afercia
Copy link
Contributor

afercia commented May 19, 2023

Description

When the editor is in 'Select' mode, the cursor style of the block mover (actually it's the 'block selection button') drag handle is grab:

Screenshot 2023-05-19 at 13 01 34

However, when the editor is in 'Edit' mode, the cursor style is pointer:

Screenshot 2023-05-19 at 13 02 11

The pointer style isn't appropriate here, as this control can't be clicked.

I think (not 100% sure) this regressed in #40379

The cursor style in previous WP version 5.7.:

wp 5 7

Step-by-step reproduction instructions

  • Go to the Post or Site editor.
  • Make sure the Editor is in 'Edit' mode.
  • Select a block: the block toolbar appears.
  • Hover the drag handle.
  • Observe the cursor style is pointer.
  • Switch the editor to 'Select' mode.
  • The block toolbar switches to the 'selection button' (that is the black sort-of-toolbar).
  • Hover the drag handle.
  • Observe the cursor style is drag.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Regression Related to a regression in the latest release [Package] Block editor /packages/block-editor labels May 19, 2023
@t-hamano
Copy link
Contributor

Fixed by #50808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

2 participants