-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browse mode: Add snackbar notices #50175
Comments
I think there's an opportunity to include snackbar notices in the theming conversations, potentially applying just a lighter gray to them. But it sems fine to move them to the center as well. |
I thought we discussed somewhere to try centering them anyhow, to reduce the visual conflicts. cc @jameskoster |
Without an in-depth exploration, I'd +1 using a lighter gray as a short-term remedy. But in general it may be worth giving the Snackbar component a design audit given the introduction of the site view. Some top-of-mind questions:
|
I did a quick fix here: #50794 |
Closed by #50794 |
The initial PR #50794 was reverted by #50937, but the problem was solved in #51054 again (c.f. #51054 (comment) and #51054 (comment)). So, I believe this issue has now been solved. |
Yes, looks like this can be closed, thanks all. |
What problem does this address?
We have removed snackbar notices from the Site Editor when in browse mode here. We need these notices to allow us to show a notice when switching to a theme (see #50030).
What is your proposed solution?
The problem is that these notices are too hard to see because they are low contrast. We should move them to the center of the browser window like this:
This was suggested by @richtabor
The text was updated successfully, but these errors were encountered: