Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable button block options for other width sizes #49652

Closed
bahiirwa opened this issue Apr 7, 2023 · 3 comments
Closed

Enable button block options for other width sizes #49652

bahiirwa opened this issue Apr 7, 2023 · 3 comments
Labels
[Block] Buttons Affects the Buttons Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement. [Type] Feature New feature to highlight in changelogs.

Comments

@bahiirwa
Copy link

bahiirwa commented Apr 7, 2023

What problem does this address?

Screenshot 2023-04-07 at 09 29 37

Looking at the Buttons block
This request seeks to provide an option for the button block to allow more options for other width sizes like 33% and 66%.
More requests for other sizes might come in so having a hook-like option would be helpful.

What is your proposed solution?

If there was a hook to add more options or even have this in the theme.json as

"blocks": {
	"core/button": {
		"widthSettings" : [ '33', '66' ]
	}
}
@bahiirwa bahiirwa changed the title Enable other button block options for other width sizes Enable button block options for other width sizes Apr 7, 2023
@skorasaurus skorasaurus added [Block] Buttons Affects the Buttons Block [Type] Enhancement A suggestion for improvement. [Type] Feature New feature to highlight in changelogs. labels Apr 10, 2023
@kevin940726
Copy link
Member

Maybe instead of adding more default options or providing hooks, we can just provide the ability to set custom width like in other settings? Here is an example of the typography size option:

image

@kevin940726 kevin940726 added the Needs Design Feedback Needs general design feedback. label Apr 11, 2023
@stokesman
Copy link
Contributor

Allowing Button as a child of Row/Stack blocks (as in #35192) is an idea that could solve this since they have dimension support.

@skorasaurus
Copy link
Member

Hi, Thanks for reporting.

This can be consolidated into #26368 which allows for custom widths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement. [Type] Feature New feature to highlight in changelogs.
Projects
None yet
Development

No branches or pull requests

4 participants