Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore using a popover for aspect ratio control #48110

Open
richtabor opened this issue Feb 15, 2023 · 1 comment
Open

Explore using a popover for aspect ratio control #48110

richtabor opened this issue Feb 15, 2023 · 1 comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

richtabor commented Feb 15, 2023

Following suite with the new shadow popover (along with existing controls like the color palette), I wanted to explore other ways to surface aspect ratio — other than a custom select that renders over the other controls in the Inspector (as proposed here).

Here's a Figma prototype with two flows (slightly different popover) — and here's the Figma doc link.

Recording

CleanShot.2023-02-15.at.15.30.50.mp4

Visuals

Popover 1:

CleanShot 2023-02-15 at 15 33 05

Popover 2:

CleanShot 2023-02-15 at 15 32 49

Notes

I've resembled the existing control that the shadow control is using. We could probably use "Original" or the like instead of having the "Aspect ratio" label display twice.

Thoughts?

@richtabor richtabor added Needs Design Feedback Needs general design feedback. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Feb 15, 2023
@richtabor
Copy link
Member Author

Not quite 1:1, but this is the original proposal for reference:

CleanShot 2023-02-15 at 15 37 02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants