Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Global Style Button block Shadow presets is empty #48061

Closed
franzaurus opened this issue Feb 14, 2023 · 5 comments
Closed

Site Editor: Global Style Button block Shadow presets is empty #48061

franzaurus opened this issue Feb 14, 2023 · 5 comments
Assignees
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Comments

@franzaurus
Copy link
Contributor

franzaurus commented Feb 14, 2023

Description

The Shadow presets popover is empty when trying to apply them to a Button block in the Global Style.

First reported on trac https://core.trac.wordpress.org/ticket/57708

It seems this is a core-specific issue, the problem does not affect the Gutenberg 15.1 plugin.

Step-by-step reproduction instructions

  1. Activate a block theme (TT3 or other)
  2. Go to Global Styles
  3. Select Button block to customize
  4. Select Shadow property
  5. Observe the Shadow presets popover is empty

Screenshots, screen recording, code snippet

shadow-block

Environment info

WP 6.2 beta 1, Firefox 109.0.1, Chrome 110.0.5481.78, Windows 11, TT3 & Powder themes.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@ndiego ndiego added the Needs Testing Needs further testing to be confirmed. label Feb 14, 2023
@ndiego
Copy link
Member

ndiego commented Feb 14, 2023

@franzaurus thanks for reporting. I am able to replicate in Beta 1, but the issue is resolved in Gutenberg trunk and will therefore get updated in Beta 2. Therefore, I am going to close this out. Thanks!

@ndiego ndiego closed this as completed Feb 14, 2023
@franzaurus
Copy link
Contributor Author

franzaurus commented Feb 15, 2023

@ndiego I find the problem is still happening in Beta 2.

@ndiego ndiego reopened this Feb 15, 2023
@ndiego
Copy link
Member

ndiego commented Feb 15, 2023

I see that too, thanks @franzaurus. Something must not have been backported. I will look into it.

@ndiego ndiego added [Type] Bug An existing feature does not function as intended and removed Needs Testing Needs further testing to be confirmed. labels Feb 15, 2023
@ndiego ndiego moved this to 📥 Todo in WordPress 6.2 Editor Tasks Feb 15, 2023
@ndiego ndiego added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Feb 15, 2023
@Mamaduka Mamaduka self-assigned this Feb 22, 2023
@Mamaduka
Copy link
Member

Mamaduka commented Feb 22, 2023

This needs another core to backport. I'll handle that.

Edit: I created a core PR to fix the bug - WordPress/wordpress-develop#4114. I will close this issue since the problem doesn't exist in the Gutenberg plugin.

@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in WordPress 6.2 Editor Tasks Feb 22, 2023
@hellofromtonya
Copy link
Contributor

The fix is from PR #46502 and this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

No branches or pull requests

4 participants