-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global Styles: display inline preview on per-block settings #42919
Comments
This comment was marked as resolved.
This comment was marked as resolved.
For anyone subscribed, this issue has been updated with design ready for a dev to pick up! |
I'll plop this on my todo list since it's near to what I've been working on 🙂 |
@noisysocks are you still planning to dig in here? Just doing a sweep of the various items on the phase 2 issue and wanted to ensure this was still assigned 💪🏼 |
Yes it's next on my list. Realistically I won't be able to start on it until 21 November. If there's a dev who has more immediate availability feel free to take it from me. |
Thanks, @noisysocks ! I'm unassigning the issue for now so that it doesn't appear as taken pm the Phase 2 board; feel free to reassign when you can start on it! |
@noisysocks @priethor I have created a very primitive version of the component here #45507 to demo box-shadow in live action. I will extract the code and create a Draft PR here. |
While #45719 addresses the Block Preview at Level 1, how shall it behave upon diving deep into the block structure? Questions to design:
CC: @WordPress/gutenberg-design |
Good question. In your box-shadow example (fresh designs herer), but also for a recent style variation example in #44417, it's actually useful to have that same top preview present not just on level 1 but on all levels. Would it be possible to keep this preview on all those sub-levels as a starting point, omit the eye for now, and then we can evaluate how that works and see if we need the eye after all? |
Let's get the preview for the top level first merged, then follow up with the sub-levels. |
When editing the global settings for a block in the "per block" section of styles, it'd be useful to render a preview at the top of the sidebar panel including the block example and how it's affected by the settings. This is relevant because global styles allows editing blocks that might not be present on the current page being previewed.
It currently looks like this:
Here's what a preview for Paragraph & Image could look like:
Upon diving deep into the structure, we can add a small preview button — the eye — to let you see a preview just like they work for style variations:
Issue was updated Sep. 28
The text was updated successfully, but these errors were encountered: