Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Editor: Unresponsive "Start Blank" and "Add all pages" buttons. Unable to add pages. #37699

Closed
mrfoxtalbot opened this issue Jan 4, 2022 · 9 comments
Labels
[Type] Bug An existing feature does not function as intended

Comments

@mrfoxtalbot
Copy link

mrfoxtalbot commented Jan 4, 2022

Description

The Navigation Editor (beta) has two options to add pages, Start Blank and Add all pages but neither of them seems to be responding.

Step-by-step reproduction instructions

Firstly follow steps here to enable the experiment.

  1. Go to /wp-admin/admin.php?page=gutenberg-navigation.
  2. Create a new menu.
  3. Try to add pages by either of the two methods mentioned above.
  4. Nothing happens :(

Screenshots, screen recording, code snippet

Kapture 2022-01-04 at 01 08 51

Environment info

  • WordPress 5.8.2 running Twenty Nineteen theme.
  • Gutenberg plugin version 12.2.0.
  • No other active plugins.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes, No

@mrfoxtalbot mrfoxtalbot added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels Jan 4, 2022
@mrfoxtalbot
Copy link
Author

I noticed the problem above alongside this other separate bug #37698

@mrfoxtalbot mrfoxtalbot changed the title Navigation (beta): Unable to add pages. Navigation (beta): Unresponsive "Start Blank" and "Add all pages" buttons. Unable to add pages. Jan 4, 2022
@carolinan
Copy link
Contributor

Hi, where does this admin path come from?

@annezazu annezazu added [Feature] Navigation Screen and removed [Block] Navigation Affects the Navigation Block labels Jan 4, 2022
@mrfoxtalbot
Copy link
Author

mrfoxtalbot commented Jan 4, 2022

Hi @carolinan! For this path to become available, the Enable Navigation Screen option needs to be checked, under "Experiments" at wp-admin/admin.php?page=gutenberg-experiments

Screen Shot on 2022-01-04 at 12:53:07

I have never reported a bug about an experimental feature, so please do let me know if there is a separate process for this.

Thank you!

@Mamaduka
Copy link
Member

Mamaduka commented Jan 6, 2022

It looks like a regression after #35746.

This is the error, I'm getting when running in dev mode:

index.js:93 Uncaught TypeError: onCreate is not a function
    at onCreateEmptyMenu (packages/edit-navigation/src/components/block-placeholder/index.js:93:3)

@mrfoxtalbot
Copy link
Author

@Mamaduka, could you please confirm if this issue is now solved so we can close it? Thank you!

@Mamaduka
Copy link
Member

Mamaduka commented Feb 3, 2022

@mrfoxtalbot, I don't believe so. Navigation Screen needs to be synced with some recent changes in Navigation Block.

cc @getdave

@getdave
Copy link
Contributor

getdave commented Feb 3, 2022

Thanks for the report!

The Nav screen is still experimental and needs updating to catch up with changes.

It will be updated based on feedback from WP 5.9.

@getdave getdave changed the title Navigation (beta): Unresponsive "Start Blank" and "Add all pages" buttons. Unable to add pages. Navigation Editor: Unresponsive "Start Blank" and "Add all pages" buttons. Unable to add pages. Feb 4, 2022
@mrfoxtalbot
Copy link
Author

mrfoxtalbot commented Jul 25, 2022

I was trying to reproduce this error but I in 13.7.2 I am no longer able to access this URL /wp-admin/admin.php?page=gutenberg-navigation and the "Enable Navigation Screen" setting under "Experiments" is now gone:

Screen Shot on 2022-07-25 at 11:58:10

I am going to close this as "Cannot Reproduce" for now but if you have a moment @getdave, could you please confirm that this is no longer a problem? Thank you!

@mrfoxtalbot mrfoxtalbot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2022
@getdave
Copy link
Contributor

getdave commented Jul 26, 2022

We've removed this screen from experiments so the bug no longer exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants