Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify or not set margin when applying inherit default layout to block #35161

Closed
karmatosed opened this issue Sep 27, 2021 · 1 comment
Closed
Labels
Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@karmatosed
Copy link
Member

When you apply 'inherit default layout' setting to a block it seems to also apply margin auto to centrally align. I might be mistaken here so would love some more testing to confirm beyond my experience.

To be clear what I am referring to is this setting:

2021-09-27 at 19 43

What I would expect to happen is it to only align centrally if the theme or you decide that. Or, if it does align, to have the option to not. You can align elements left but then you get floating issues which isn't that great for layout and can get really complicated fast.

My recommendation is to probably not set it by default, however, I would appreciate knowing if just myself experiencing this or others also.

@karmatosed karmatosed added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. labels Sep 27, 2021
@karmatosed
Copy link
Member Author

This has sat here a while and the area it has impact on has changed. For now, I am going to close this as my own ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

1 participant