Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get useInnerBlocksProps hook out of experimental status #35071

Closed
fabiankaegy opened this issue Sep 23, 2021 · 3 comments · Fixed by #26031
Closed

Get useInnerBlocksProps hook out of experimental status #35071

fabiankaegy opened this issue Sep 23, 2021 · 3 comments · Fixed by #26031
Assignees
Labels
[Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P [Package] Block editor /packages/block-editor [Type] Experimental Experimental feature or API.

Comments

@fabiankaegy
Copy link
Member

What problem does this address?

The useInnerBlocksProps hook was added in October 2020 via #25633 as an experimental hook. Since its release, a few bugs have appeared (#34120, #30408, #29513, #29482, #29036, #14242) but, in general, no breaking feedback has been received. However, this might be either because the hook version is very stable or because of a lack of wider testing.

What is your proposed solution?

We should consider moving the useInnerBlocksProps out from experimental as the next step towards wider adoption and as a means to receive more organic feedback from users.

Alternate options

If we feel it is not ready to be marked as a stable API I think we would benefit from adding some experimental documentation for plugin authors etc to test this hook and provide feedback.

@fabiankaegy fabiankaegy added [Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P [Package] Block editor /packages/block-editor [Type] Experimental Experimental feature or API. labels Sep 23, 2021
@fabiankaegy
Copy link
Member Author

@ellatrix Since you are the brain behind the hook implementation do you see any reason why the hook would not be ready?

Would love to get your thoughts on this :) Thanks in advance!

@ellatrix
Copy link
Member

There's a PR that's been around for a while: #26031. I'll rebase it.

@cr0ybot
Copy link
Contributor

cr0ybot commented Sep 24, 2021

Very excited for this. I've wanted to use it but I refrain from using experimental APIs since they will break when experimental status is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P [Package] Block editor /packages/block-editor [Type] Experimental Experimental feature or API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants