-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment Date Block #30573
Comments
@jameskoster thanks so much for this exploration! While you're exploring this, I wanted to loop in some feedback that came out of a stream from a contributor where she mentioned that the date selection is currently unstyled: Is this something you plan to address here? I wasn't able to see it in the figma file so wanted to check to be sure. |
@annezazu I think that is a separate issue altogether. Looks like a bug in the Post Date block. |
Facepalm -- got my date blocks confused. Thank you. Sorry about that! |
Hi James It looks like you have the added options needed for this block. |
The first iteration of this block as "Post Comment Date" was added in #24854 |
Noting that a common use case for the comment published date is to wrap it in the permalink for the comment. Maybe a "link to comment" would make for a good option. |
Hello! 👋 I would like to wrap up all the issues related to the Post Comments block to start working on a Comment Loop block as explained in this tracking issue. I'd like to make a quick summary to ensure we are aligned on this one: DescriptionAdd the date of the specific comment. Potential Settings
References
Of course, any feedback is welcome 🙂 |
I see that #35112 for Link Settings is close to ready. @carolinan, do you plan to continue working on other enhancements that @SantosGuillamot proposed? |
After #35112 there is nothing left to do on the checklist. I only mentioned that it was a partial pull request because it can't be tested inside a comment template /comment loop yet. |
That's awesome. Thank you for the clarification @carolinan. Let's close this issue once #35112 land then 😄 I wasn't aware that other features require only feature toggles. As simple as that 🎉 |
Here is an initial take on the design for the Comment Date block. This block should only be available in the Site Editor, and potentially only when editing certain templates (Index, Single, Singular, Page).
Design feedback is politely requested for all aspects:
Figma link here.
The text was updated successfully, but these errors were encountered: