Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Blocks Inside Reusable Blocks: Top-Level Cannot Be Edited, Sub-Level Removed from Tab Order #19373

Closed
0aveRyan opened this issue Dec 31, 2019 · 5 comments
Labels
[Block] Block The "Reusable Block" Block [Block] Group Affects the Group Block (and row, stack and grid variants) [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@0aveRyan
Copy link
Contributor

0aveRyan commented Dec 31, 2019

Describe the bug
Inside of Reusable Blocks, Group Blocks cannot be accessed by keyboard navigation for top-level or nested Group Blocks. While nested Group Blocks can be clicked into, top-level Group Blocks inside a Reusable Block cannot be clicked or accessed by keyboard.

As noted in #19372, the Block Navigation doesn't reveal the contents of Reusable Blocks, so it's impossible to edit Group Block settings at the top-level and quite challenging to edit nested Group Blocks.

To reproduce
Steps to reproduce the behavior:

  1. Insert a Group Block (recommend giving a Background Color for visibility)
  2. Insert a Paragraph inside the Group Block.
  3. Insert a nested Group Block inside the Group Block (recommend giving a different Background Color)
  4. Insert a Paragraph inside the nested Group Block.
  5. Attempt to access Group Block settings via TAB/Shift+TAB keyboard navigation.
  6. Attempt to access Group Block settings via mouse clicks (only a mouse click in the upper right corner of the nested Group Block, outside the Paragraph block boundary will trigger the toolbar and Block selection. No way to click or TAB into the top-level Group Block)

Worth noting, this behavior doesn't occur inside Reusable Blocks with Columns or other blocks containing child blocks. This behavior only happens inside of Reusable Blocks, not when Group blocks are inserted into normal Post Content.

Expected behavior
Group Blocks need to be able to be tabbed into for a11y and general usability reasons. Group Blocks should also be selectable via mouse click, as this is likely to be the more common use case. Ideally, Reusable Blocks' contents should be shown in the Block Navigation (#19372) as a reliable way to select Groups and trigger toolbar/sidebar to initialize.

Screenshots
Screen Shot 2019-12-31 at 8 55 37 AM

WordPress: Version 5.3.3-alpha-46995

@0aveRyan 0aveRyan added [a11y] Keyboard & Focus [Block] Block The "Reusable Block" Block [Block] Group Affects the Group Block (and row, stack and grid variants) [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Bug An existing feature does not function as intended labels Dec 31, 2019
@paaljoachim
Copy link
Contributor

paaljoachim commented Jan 18, 2021

Hey @0aveRyan David

Thanks for creating the issue!
Is this issue still valid?

There is a general cleanup of Reusable blocks happening lately. Here is an overview issue.
#27890

@paaljoachim
Copy link
Contributor

Testing using WordPress 5.7.1. Twenty Twenty One. Gutenberg plugin 10.5.

Focusing on mouse clicks:

Clicking-parent-icon.mp4

I am able to select both Group block settings.

@paaljoachim
Copy link
Contributor

Could you Joe @joedolson or Stefano @Ryokuhi check to see if this issue is still valid?
Thank you!

@shikkaba
Copy link

I wonder if this is related to the glitch I'm having where you can't see content inside a nested group block unless you switch preview from desktop.

Not reporting it here, it just seems to be the same block stack that is causing problems.

@priethor priethor added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [a11y] Keyboard & Focus labels Jul 24, 2023
@jordesign
Copy link
Contributor

Seeing no confirmation this is still an issue - I'm going to close it for now. It if does prove to be a problem still we can re-open it.

@jordesign jordesign closed this as not planned Won't fix, can't repro, duplicate, stale Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Block The "Reusable Block" Block [Block] Group Affects the Group Block (and row, stack and grid variants) [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants