DataForm: introduce isLoading prop

WordPress · Dec 6, 2024 · e4df49f · e4df49f
1 parent 5896920
commit e4df49f
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 9 deletions.
diff --git a/packages/dataviews/src/components/dataform/index.tsx b/packages/dataviews/src/components/dataform/index.tsx
@@ -16,13 +16,14 @@ export default function DataForm< Item >( {
 	form,
 	fields,
 	onChange,
+	isLoading = false,
 }: DataFormProps< Item > ) {
 	const normalizedFields = useMemo(
 		() => normalizeFields( fields ),
 		[ fields ]
 	);
 
-	if ( ! form.fields ) {
+	if ( ! form.fields || isLoading ) {
 		return null;
 	}
 

diff --git a/packages/dataviews/src/types.ts b/packages/dataviews/src/types.ts
@@ -543,6 +543,7 @@ export interface DataFormProps< Item > {
 	fields: Field< Item >[];
 	form: Form;
 	onChange: ( value: Record< string, any > ) => void;
+	isLoading?: boolean;
 }
 
 export interface FieldLayoutProps< Item > {

diff --git a/packages/edit-site/src/components/post-edit/index.js b/packages/edit-site/src/components/post-edit/index.js
@@ -35,17 +35,22 @@ const fieldsWithBulkEditSupport = [
 
 function PostEditForm( { postType, postId } ) {
 	const ids = useMemo( () => postId.split( ',' ), [ postId ] );
-	const { record } = useSelect(
+	const { record, hasFinishedResolution } = useSelect(
 		( select ) => {
+			const args = [ 'postType', postType, ids[ 0 ] ];
+
+			const {
+				getEditedEntityRecord,
+				hasFinishedResolution: hasFinished,
+			} = select( coreDataStore );
+
 			return {
 				record:
-					ids.length === 1
-						? select( coreDataStore ).getEditedEntityRecord(
-								'postType',
-								postType,
-								ids[ 0 ]
-						  )
-						: null,
+					ids.length === 1 ? getEditedEntityRecord( ...args ) : null,
+				hasFinishedResolution: hasFinished(
+					'getEditedEntityRecord',
+					args
+				),
 			};
 		},
 		[ postType, ids ]
@@ -162,6 +167,7 @@ function PostEditForm( { postType, postId } ) {
 			<PostEditHeader postType={ postType } postId={ postId } />
 			<DataForm
 				data={ ids.length === 1 ? record : multiEdits }
+				isLoading={ ! hasFinishedResolution }
 				fields={ fieldsWithDependency }
 				form={ form }
 				onChange={ onChange }