Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback - Incorrect Error Message on Content Feedback Form #3026

Closed
nobodys-ghost opened this issue Nov 14, 2024 · 5 comments
Closed

Feedback - Incorrect Error Message on Content Feedback Form #3026

nobodys-ghost opened this issue Nov 14, 2024 · 5 comments
Labels
Priority - Medium Medium priority issue. [Type] Bug Something isn't working on the Learn website.

Comments

@nobodys-ghost
Copy link

Type of feedback

//dev

Description

When using the form on the Report Content Feedback page, putting the URL of the Intro to the Site Editor YouTube video prompts the error message "Please enter a valid URL", despite the fact it is a valid URL.

Step-by-step reproduction instructions (optional)

  1. Go to the Report Content Feedback page
  2. Input the URL of the above YouTube video https://www.youtube.com/watch?v=ILgA2GemwO0
  3. Click send

Screenshots or screen recording (optional)

Image

Other information (optional)

  • I'm on Windows 11, running firefox version 132.0.2
  • I tried to replicate the behavior with a few other valid URLs that end in query strings, and it threw the same error message for all of them
  • I already reported the typo mentioned in the above screenshot.
@nobodys-ghost nobodys-ghost added the Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. label Nov 14, 2024
@github-actions github-actions bot added the [Type] Bug Something isn't working on the Learn website. label Nov 14, 2024
@jonathanbossenger
Copy link
Collaborator

Hi @nobodys-ghost thanks for opening this issue.

The content feedback form on the Learn.WordPress.org website seems to require you to enter a link to a URL on the site.

@adamwoodnz could you confirm if this is indeed the case?

@jonathanbossenger jonathanbossenger added Priority - Medium Medium priority issue. and removed Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. labels Nov 28, 2024
@adamwoodnz
Copy link
Contributor

adamwoodnz commented Nov 28, 2024

I've tested and it seems to be the URL parameter that fails the validation, as https://www.youtube.com/watch passes, but https://www.youtube.com/watch?v=ILgA2GemwO0 does not.

We are not doing anything custom with validation here, it's a standard Jetpack contact form URL field. If we really want to support this format we'll need to raise an issue with Jetpack.

I guess the intended use of this form is for content on our platform, so reporting on our YouTube content is slightly unusual. Is this video embedded in one of our Lessons?

@nobodys-ghost
Copy link
Author

It's embedded in the Intro to the Site Editor lesson of the beginner WordPress course.

@adamwoodnz
Copy link
Contributor

Thanks, I imagine that URL is what we'd expect to be entered into the feedback form 🙂

@jonathanbossenger
Copy link
Collaborator

Thanks everyone. So, while it seems that the bug does exist in the Jetpack form, it's also true that the URL we'd need to capture on that form is to content on learn.wordpress.org. The main reason for this is that if a change is required for the video, we'd also need to update the content on the lesson. So it's a happy coincidence that this "bug" reinforces that.

I've updated the form to make it clearer that the user needs to use URLs to content on learn.wordpress.org, and I'll close this issue.

@nobodys-ghost if you would like to report the bug to the Jetpack repository, you can do so here: https://github.com/Automattic/jetpack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority - Medium Medium priority issue. [Type] Bug Something isn't working on the Learn website.
Projects
Status: Done
Development

No branches or pull requests

3 participants