-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single Lesson: Polish the design #2638
Comments
Do we have room now to revisit the design of lessons @renintw @adamwoodnz? I noticed a few inconsistencies and room for improvement in terms of spacing and text styles that also relate to #2809 |
Hi @fcoveram 👋 regarding #2809, I noticed that there isn't a related design presented in Figma (or am I missing it?). #2809 refers to the "Lesson Completed" indicator, which appears after clicking "Complete Lesson." It was removed in #2806 due to the reasons @ryelle mentioned below. Could we consider redesigning it based on Kelly's or my ideas? Thanks! From Kelly #2806 (comment)
Mine #2806 (comment)
|
You are right. Sorry for that. I've been busy with the designs for Five for the Future.
Absolutely. I have in my notes that change.
Green is definitely more consistent. Sorry for not addressing the changes timely. The mockups are outdated so please wait for my ping to make sure I delivery the correct designs. Thanks |
There’s some design work for the full-screen lessons that lives in Figma here, that could be worth looking at. I realize it may be limited what you can do here, but there are some things about icons, positioning, sizes, etc, that could benefit from small tweaks.
The text was updated successfully, but these errors were encountered: