Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL Audit #2483

Closed
3 tasks done
adamwoodnz opened this issue May 31, 2024 · 8 comments · Fixed by #2669
Closed
3 tasks done

RTL Audit #2483

adamwoodnz opened this issue May 31, 2024 · 8 comments · Fixed by #2669
Assignees
Labels
[Component] Learn Theme Website development issues related to the Learn theme. [Component] Sensei Website development issues related to the Sensei plugin installed on Learn. [Type] Bug Something isn't working on the Learn website.

Comments

@adamwoodnz
Copy link
Contributor

adamwoodnz commented May 31, 2024

  • Change to a right to left language and browse the site
  • Log issues as comments below
  • Fix issues
@adamwoodnz adamwoodnz converted this from a draft issue May 31, 2024
@adamwoodnz adamwoodnz added the [Component] Learn Theme Website development issues related to the Learn theme. label May 31, 2024
@adamwoodnz adamwoodnz added this to the Learning Pathways launch milestone May 31, 2024
@ironnysh
Copy link

ironnysh commented Jun 9, 2024

Hi @adamwoodnz, happy to help with this audit.
As a native Hebrew speaker, RTL is the bane of my existence 😅

@adamwoodnz
Copy link
Contributor Author

adamwoodnz commented Jun 9, 2024

Hi @adamwoodnz, happy to help with this audit. As a native Hebrew speaker, RTL is the bane of my existence 😅

Awesome! I'll move this into 'To do' once we're far enough along with the build to start. Thanks 🙂

@adamwoodnz adamwoodnz moved this from ⚠ On Hold/Blocked to 📋 To do in WordPress.org Jul 8, 2024
@adamwoodnz
Copy link
Contributor Author

Hi @ironnysh I think this is ready thanks

@ironnysh
Copy link

ironnysh commented Jul 8, 2024

Great, thanks for the heads-up, @adamwoodnz!

Would screenshots work for logging the issues?

@adamwoodnz
Copy link
Contributor Author

Would screenshots work for logging the issues?

Yes please, with direct links to the page in question.

@ironnysh
Copy link

ironnysh commented Jul 9, 2024

Hey @adamwoodnz, I checked the site as a logged-in and random user on desktop Safari and Chrome in different breakpoints.
Here's a list of findings:

Lesson page

URL: https://learn.wordpress.org/lesson/how-to-find-help-with-wordpress-2/ (on all courses)
lesson-inside-lp


Top nav / main nav

URL: https://learn.wordpress.org/ (across the site, different bugs depending on the breakpoint)
601-889 pixels breakpoint:
drop-down-menu

Mobile:
mobile-menu

Standard desktop:
top-menu-lp
top-nav


Learning Pathway homepage

URL: https://learn.wordpress.org/learning-pathways/
lp-homepage


Online workshops homepage

URL: https://learn.wordpress.org/online-workshops/
spacing-workshops-page


Course homepage

URL: https://learn.wordpress.org/course/beginner-wordpress-developer/ (on all courses)
course-homepage_top
course-homepage


My courses

URL: https://learn.wordpress.org/my-courses/
my-courses


Quiz

URL: https://learn.wordpress.org/quiz/wordpress-taxonomies-2/ (on all courses)
quiz-spacing


Query filter

URLs: https://learn.wordpress.org/lessons/, https://learn.wordpress.org/courses/, https://learn.wordpress.org/learning-pathway/developer/ (wherever there’s the wp-block-wporg-query-filter class):
query-filter-cut
query-filter-cut_2
query-filter_wrong-direction

@ryelle
Copy link
Contributor

ryelle commented Jul 9, 2024

Some of these, especially the "Top nav / main nav" items, appear to be site-wide issues (across all wporg sites). I can handle these, since they're generally components I'm familiar with.

Local nav

  • Misaligned submenus
  • Missing left/right space on local nav
  • My courses has poor spacing with dot 9661a4e
  • Local nav W logo on the wrong side

My courses

Query Filters

  • Dropdown alignment should be switched on RTL

@adamwoodnz
Copy link
Contributor Author

Hey @adamwoodnz, I checked the site as a logged-in and random user on desktop Safari and Chrome in different breakpoints.

Thanks! Great work.

@adamwoodnz adamwoodnz moved this from 📋 To do to 🏗 In progress in WordPress.org Jul 9, 2024
@adamwoodnz adamwoodnz added [Type] Bug Something isn't working on the Learn website. [Component] Sensei Website development issues related to the Sensei plugin installed on Learn. labels Jul 9, 2024
ryelle added a commit to WordPress/wporg-parent-2021 that referenced this issue Jul 9, 2024
For flex layouts, Gutenberg translates "left" and "right" into "flex-start" and "flex-end" respectively. Flipping these for RTL sites actually has the wrong effect, because in RTL "left" (flex-start) is visually on the right, which is correct already (despite being wrong descriptively).

See WordPress/Learn#2483, Follow-up to 2a95d17
DanyloKubyshkin added a commit to DanyloKubyshkin/wordpress-org that referenced this issue Jul 12, 2024
For flex layouts, Gutenberg translates "left" and "right" into "flex-start" and "flex-end" respectively. Flipping these for RTL sites actually has the wrong effect, because in RTL "left" (flex-start) is visually on the right, which is correct already (despite being wrong descriptively).

See WordPress/Learn#2483, Follow-up to WordPress/wporg-parent-2021@2a95d17
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in WordPress.org Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Learn Theme Website development issues related to the Learn theme. [Component] Sensei Website development issues related to the Sensei plugin installed on Learn. [Type] Bug Something isn't working on the Learn website.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants