-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL Audit #2483
Comments
Hi @adamwoodnz, happy to help with this audit. |
Awesome! I'll move this into 'To do' once we're far enough along with the build to start. Thanks 🙂 |
Hi @ironnysh I think this is ready thanks |
Great, thanks for the heads-up, @adamwoodnz! Would screenshots work for logging the issues? |
Yes please, with direct links to the page in question. |
Hey @adamwoodnz, I checked the site as a logged-in and random user on desktop Safari and Chrome in different breakpoints. Lesson pageURL: https://learn.wordpress.org/lesson/how-to-find-help-with-wordpress-2/ (on all courses) Top nav / main navURL: https://learn.wordpress.org/ (across the site, different bugs depending on the breakpoint) Learning Pathway homepageURL: https://learn.wordpress.org/learning-pathways/ Online workshops homepageURL: https://learn.wordpress.org/online-workshops/ Course homepageURL: https://learn.wordpress.org/course/beginner-wordpress-developer/ (on all courses) My coursesURL: https://learn.wordpress.org/my-courses/ QuizURL: https://learn.wordpress.org/quiz/wordpress-taxonomies-2/ (on all courses) Query filterURLs: https://learn.wordpress.org/lessons/, https://learn.wordpress.org/courses/, https://learn.wordpress.org/learning-pathway/developer/ (wherever there’s the |
Some of these, especially the "Top nav / main nav" items, appear to be site-wide issues (across all wporg sites). I can handle these, since they're generally components I'm familiar with. Local nav
My courses
Query Filters
|
Thanks! Great work. |
For flex layouts, Gutenberg translates "left" and "right" into "flex-start" and "flex-end" respectively. Flipping these for RTL sites actually has the wrong effect, because in RTL "left" (flex-start) is visually on the right, which is correct already (despite being wrong descriptively). See WordPress/Learn#2483, Follow-up to 2a95d17
For flex layouts, Gutenberg translates "left" and "right" into "flex-start" and "flex-end" respectively. Flipping these for RTL sites actually has the wrong effect, because in RTL "left" (flex-start) is visually on the right, which is correct already (despite being wrong descriptively). See WordPress/Learn#2483, Follow-up to WordPress/wporg-parent-2021@2a95d17
The text was updated successfully, but these errors were encountered: