Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement proper caching of Airtable requests (add state management?) #146

Open
tuttiq opened this issue Sep 19, 2020 · 2 comments
Open
Labels
enhancement New feature or request help wanted Extra attention is needed performance

Comments

@tuttiq
Copy link
Collaborator

tuttiq commented Sep 19, 2020

Is your feature request related to a problem? Please describe

The current caching logic doesn't work, so we're still making requests to Airtable to get the full list of prefectures, languages and topics every time we load the speaker list and the nominate form.

Since we shouldn't have any more N+1 requests problem, it's a not a huge deal right now, but could improve the performance slightly and more as we add more pages to the site in the future (speaker profile page, etc?).

Describe the solution you'd like

I think we should probably just add centralized state management with Vuex.

Describe alternatives you've considered

I tried a few workarounds for caching, but they all have problems (serializing/deserializing data, etc).

@tuttiq tuttiq added enhancement New feature or request performance labels Sep 19, 2020
@ann-kilzer ann-kilzer added the help wanted Extra attention is needed label Sep 30, 2020
@ann-kilzer
Copy link
Collaborator

lolololol we should fix this, it's making the page load slower and slower as our userbase grows

SpeakHer

@tuttiq
Copy link
Collaborator Author

tuttiq commented Sep 30, 2020

The short term solution is already implemented here: #144 .

This ticket is for a longer-term solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed performance
Projects
None yet
Development

No branches or pull requests

2 participants