Added MainMenu/PauseMenu/NewLevel/Rain/GunOverHeat #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gun.cs - added overheat system Pauser.cs - disabled and use my own script for PauseMenu Remover.cs - go back to MainMenu when the player die
Please add them to build setting for everything to work smoothly
Please add scenes to build setting for everything to go smoothly. Also rain effect might be off because it doesn't automatically locate RainMat so if you can please do so under Rain/Partical System/Renderer(inspector)/Material
nullorvoid
reviewed
Jun 6, 2018
| @@ -45,7 +45,7 @@ void FixedUpdate () | |||
| } | |||
|
|
|||
| // Set the enemy's velocity to moveSpeed in the x direction. | |||
| rigidbody2D.velocity = new Vector2(transform.localScale.x * moveSpeed, rigidbody2D.velocity.y); | |||
| GetComponent<Rigidbody2D>().velocity = new Vector2(transform.localScale.x * moveSpeed, GetComponent<Rigidbody2D>().velocity.y); | |||
There was a problem hiding this comment.
Looking at this PR I spotted the use of GetComponent inside update and fixed update loops. How do you think this could be made more efficient?
There was a problem hiding this comment.
Instead of calling GetComponent() every time it loop, have a reference variable so you only need to call GetComponent() once and use that reference variable to update the velocity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add scenes to build setting for everything to go smoothly. Also rain effect might be off because it doesn't automatically locate RainMat so if you can please do so under Rain/Partical System/Renderer(inspector)/Material.
Added:
MyImages folder - images I used to create the new level/gameplay
MyScripts folder - store all the scripts I made for the main menu and pause menu
MainMixer - to adjust the volume of the game
RainMat - for rain effect
New Scenes - including MainMenu, Level 1, and Level 2
Changed:
Gun.cs - added overheat system
Remover.cs - changed so that it will return to main menu when player die
Pauser.cs - disabled to use my own pause scripts