Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support writing of cross-endian files #76

Open
evanmiller opened this issue Aug 1, 2016 · 4 comments
Open

Support writing of cross-endian files #76

evanmiller opened this issue Aug 1, 2016 · 4 comments

Comments

@evanmiller
Copy link
Contributor

Currently little-endian machines can only write little-endian files, and big-endian machines can write only big-endian files. Support for cross-endian writes will let us bring cross-endian reads under test coverage.

@QuLogic
Copy link

QuLogic commented May 17, 2019

FWIW, the haven test suite passes on s390x, a big endian architecture. I don't know if any of the tests actually exercise endianness, though.

@evanmiller
Copy link
Contributor Author

@QuLogic Thanks, good to know. The tests all write to their native endianness and read from the same, so there are still untested code paths.

@QuLogic
Copy link

QuLogic commented May 17, 2019

Ah, I was hoping some of those existing files in the test suite might have exercised this code path.

@evanmiller
Copy link
Contributor Author

I should have clarified - the ReadStat tests are all native roundtrips. I believe the haven tests use a suite of files, and therefore will test at least some of the byteswapping code paths on a big-endian machine.

I don't know how comprehensive the haven tests are, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants