Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement flexible generation of path #5

Open
ilatif opened this issue Aug 25, 2014 · 3 comments
Open

Implement flexible generation of path #5

ilatif opened this issue Aug 25, 2014 · 3 comments

Comments

@ilatif
Copy link
Contributor

ilatif commented Aug 25, 2014

Presently for CSS and JavaScript tags, path is generated like <script src='/assets/js/application.js'></script>. This path restrict browsers to fetch resources from root. Many a times during local development most developers don't create virtual-host and prefer to run web-apps under some directory in web-root which creates path like http://localhost/my_web_app. Inserting / before paths makes it difficult for those developers to use this library.

A clean way to achieve abstraction is to use CodeIgniter's built-in site_url method to generate path for assets. This will create correct path in every case.

@ilatif
Copy link
Contributor Author

ilatif commented Oct 30, 2014

Hi @SeanNieuwoudt. Do you want me to address these issues. I would love to work on them. 😄

Looking forward to hear from you.

Thanks.

@sn
Copy link
Member

sn commented Oct 31, 2014

Hi @ilatif,

That would be great & very much appreciated.

Thanks in advance!

Sean

@ilatif
Copy link
Contributor Author

ilatif commented Oct 31, 2014

@SeanNieuwoudt,

Awesome. Thanks for giving me a green signal 👍

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants