We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should add a rule to suggest await over Task.Result or Task.Wait() within methods returning Task (potentially requiring the method to be made async).
await
Task.Result
Task.Wait()
Task
async
Should probably also apply within methods that are already async void, but definitely shouldn't suggest making a method async void.
async void
The text was updated successfully, but these errors were encountered:
.Result could be acceptable if it has already been awaited with Task.WhenAll and friends.
Should also look for .GetAwaiter().GetResult()
Sorry, something went wrong.
Good point, also when accessed from within the Task.ContinueWith callback.
Task.ContinueWith
No branches or pull requests
Should add a rule to suggest
await
overTask.Result
orTask.Wait()
within methods returningTask
(potentially requiring the method to be madeasync
).Should probably also apply within methods that are already
async void
, but definitely shouldn't suggest making a methodasync void
.The text was updated successfully, but these errors were encountered: