Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorites button on toolbar gets camouflaged (hidden) in the dark and black themes #36

Open
shubhamnanche opened this issue Dec 29, 2024 · 1 comment
Assignees

Comments

@shubhamnanche
Copy link
Contributor

Describe the bug
Near invisible visibility of the favorites button in the toolbar when the app is in black or dark theme.

To Reproduce
Steps to reproduce the behavior:

  1. Launch app (in the first launch, the default theme is Light)
  2. Change the theme to Black or Dark using the theme button in the toolbar
  3. Observe that the Favorites button in the toolbar is camouflaged.

Expected behavior
Clear visibility of the favorites button is expected.

Screenshots
Light Theme Look
Dark Theme Look

@WirelessAlien
Copy link
Owner

I think that will be fixed if android:tint="?attr/colorControlNormal" is added like this -

<vector android:height="24dp" android:tint="#000000"
    android:viewportHeight="24" android:viewportWidth="24"
    android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android"
android:tint="?attr/colorControlNormal">
    <path android:fillColor="@android:color/white" android:pathData="M16.5,3c-1.74,0 -3.41,0.81 -4.5,2.09C10.91,3.81 9.24,3 7.5,3 4.42,3 2,5.42 2,8.5c0,3.78 3.4,6.86 8.55,11.54L12,21.35l1.45,-1.32C18.6,15.36 22,12.28 22,8.5 22,5.42 19.58,3 16.5,3zM12.1,18.55l-0.1,0.1 -0.1,-0.1C7.14,14.24 4,11.39 4,8.5 4,6.5 5.5,5 7.5,5c1.54,0 3.04,0.99 3.57,2.36h1.87C13.46,5.99 14.96,5 16.5,5c2,0 3.5,1.5 3.5,3.5 0,2.89 -3.14,5.74 -7.9,10.05z"/>
</vector>

Actually it is needed to be added in all drawable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants