Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window position isn't saved #7

Closed
Windows200000 opened this issue May 17, 2024 · 5 comments
Closed

Window position isn't saved #7

Windows200000 opened this issue May 17, 2024 · 5 comments
Labels
Enhancement New feature or request

Comments

@Windows200000
Copy link
Owner

Issue ported from issue in original repo


Very tiny annoyance but I use this app on a 2nd monitor and with all the restarts it's starting to become annoying.

@Windows200000 Windows200000 added the Enhancement New feature or request label May 17, 2024
@Windows200000
Copy link
Owner Author

@notNSANE I've got this working, there is however an issue: If you move the window to your second monitor, close TDM, disconnect the monitor and then open TDM, it will forecfully put itself off screen.

I fixed this by not hiding the tray icon when maximized (I was annoyerd by it popping in and out anyways) and adding an option, that just puts it to the top left of the main monitor.

Should be in the latest in-dev soon.

@Windows200000
Copy link
Owner Author

@notNSANE It's built: in-dev

@notNSANE
Copy link

notNSANE commented Jun 13, 2024

beautiful, thanks!

And I believe the disconnect monitor issue is "global" (as in, should happen to most apps).

Can't close the issue, so it's up to you.

@Windows200000
Copy link
Owner Author

@notNSANE

And I believe the disconnect monitor issue is "global" (as in, should happen to most apps).

Not really. Windows moves apps to your main monitor, if you disconnect one. The issue is only if it changes in between runs, because the window is just forced to be drawn at coordinates, that are now off-screen. I could have fixed this in a cleaner way, but that would require additional dependencies or an OS-dependent solution. I suspect this will be rare anyway, but a simple tray option is nicer than having to manually edit the .json, especially as most people wouldn't even think to do that.

@Windows200000
Copy link
Owner Author

Works on Linux, I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants