Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Want to add a setting with a fixed refresh time. #67

Open
coolingziyu opened this issue May 26, 2024 · 13 comments
Open

Want to add a setting with a fixed refresh time. #67

coolingziyu opened this issue May 26, 2024 · 13 comments
Labels
Enhancement New feature or request

Comments

@coolingziyu
Copy link

coolingziyu commented May 26, 2024

Want to add one that can be refreshed at a specified time after startup. For example: I started the app at 21:47, which may make some of the short time to drops can not complete the viewing task, want him to automatically refresh the list on the next hour (of course, it can be other times), so that I do not need to start the app at the hour. After the completion of the treasure refresh time will be confused, hope that after the completion of the treasure, can refresh the next hour (can also be other time). Could you please make this function?

@coolingziyu
Copy link
Author

Sorry, I can only use software translation, I hope you can understand.

@Windows200000
Copy link
Owner

I am sorry, I do not understand what you mean. Maybe try writing it in your native language and telling ChatGPT to translate it with proper context?

@Windows200000
Copy link
Owner

I think you mean something similar to this in the original repo.

As far as I understand, the miner does already track drops, that are upcoming. Do the campaigns appear on twitch right as they start, making it impossible to see them in advance, or is the issue that the miner prioritizes not switching from what is currently being mined?

@Windows200000 Windows200000 added the Enhancement New feature or request label May 26, 2024
@coolingziyu
Copy link
Author

coolingziyu commented May 26, 2024

Yes, I mean something similar to what he said.

@coolingziyu
Copy link
Author

I would like to add a feature that allows the app to load at a fixed time after it is launched. For example, if I launch the app at 21:47, it may load again at 22:47 the next time. However, if there is a treasure drop task that starts at 22:00 and ends at 23:00, and it requires watching for 30 minutes, I will only be able to hang for 13 minutes if I wait for the app to refresh automatically. This is not enough time, so I need the app to load around 22:01.

@Windows200000
Copy link
Owner

Windows200000 commented May 26, 2024

@coolingziyu What you are proposing would be a janky solution.

That's why I asked this: Do the campaigns appear on twitch right as they start, making it impossible for the bot to see them in advance, or is the issue that the miner keeps mining what he is currently mining causing the miss?

@coolingziyu
Copy link
Author

Yes, the program can't see.

@coolingziyu
Copy link
Author

"The second example is: the treasure drop app successfully completes a treasure drop, but the completion time is 17:37, so the next refresh time will be at 18:37. If the same treasure drop task mentioned earlier occurs again, the watch time may not be enough. Therefore, it is hoped that the list can be refreshed around 18:01 after completing the treasure drop, instead of 18:37."

@coolingziyu
Copy link
Author

coolingziyu commented May 26, 2024

@coolingziyu What you are proposing would be a janky solution.

That's why I asked this: Do the campaigns appear on twitch right as they start, making it impossible for the bot to see them in advance, or is the issue that the miner keeps mining what he is currently mining causing the miss?

"Yes, this method is clumsy, and currently I rely on the Windows system timer to restart the app once every 24 hours to set the refresh time to the appropriate time."
"I believe you can come up with a better and more technical solution."

@Windows200000
Copy link
Owner

Thanks, I'll look into that in the future, if I find the time. IT would probably be either a box where you input a time to reload, a setting adjusting the reload frequency, or a new function that periodically checks for new campaigns without a reload.

@coolingziyu
Copy link
Author

"Thank you for listening, and I look forward to your optimization of the program."

@test137E29B
Copy link

I think you mean something similar to this in the original repo.

As far as I understand, the miner does already track drops, that are upcoming. Do the campaigns appear on twitch right as they start, making it impossible to see them in advance, or is the issue that the miner prioritizes not switching from what is currently being mined?

Can confirm this is the exact thing happening to me, with the WF drops. I'll take a look at getting a PR up that adds a setting for reload frequency in mins. I saw your comment that you're away for exams / work for a while, but wanted to ask that when adding something new with English only localisation, what's the process for it being missing from other languages? What kind of safeguards would you think are best here too - like less than 15 mins reload frequency should not be allowed for example?

@Windows200000
Copy link
Owner

Windows200000 commented Jun 21, 2024

@test137E29B

when adding something new with English only localisation, what's the process for it being missing from other languages?

If added to English.json, it should automatically appear on git localize, where people can then translate. Until it's translated, the English version is shown.

What kind of safeguards would you think are best here too - like less than 15 mins reload frequency should not be allowed for example?

I don't think there is a time that is both safe for not alerting twitch and frequent enough to actually work. Afaik, there are some drops that are really tight, where even the 15 mins might not be enough. The proper solution would be, as DevilXD said somewhere, a mechanism that doesn't do a whole refresh, but just checks for drops and reloads only if necessary. As for a quick solution to make it work, I think the best thing would be a box to enter a time at which a reload will happen. From what I remember, the code already uses a set time as a trigger for the next reload, it's just statically set to an hour in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants