Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add insta-based snapshot tests that cover side-by-side format #730

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add insta-based snapshot tests that cover side-by-side format #730

wants to merge 3 commits into from

Commits on Oct 2, 2024

  1. Drop executable bit from sample_files/chinese_1.po 

    I don't think this is intentional, and it would introduce test instability on
Windows CI.
    @yuja
    yuja committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    c5398d1 View commit details
    Browse the repository at this point in the history

  2. Add insta dev-dependency

    @yuja
    yuja committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    0b6b3ec View commit details
    Browse the repository at this point in the history

  3. Add insta-based snapshot tests that cover side-by-side format 

    I'm going to fix inline diff issue Wilfred#704, and found that the inline format isn't
covered by CLI tests. I could duplicate compare_all.sh to test various formats,
but it's uneasy to review that a new formatting is better than the previous
version. I think snapshot testing will help guarantee the output quality without
increasing maintenance burden too much.

If we like the idea, maybe we can migrate some of compare_all.sh tests to the
insta-based ones.

Note that this will add ~10sec to "cargo test" runs.
    @yuja
    yuja committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    23fe981 View commit details
    Browse the repository at this point in the history