Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FA2 and rotary positional embeddings #16

Open
benjamin-kroeger opened this issue Dec 7, 2024 · 1 comment
Open

FA2 and rotary positional embeddings #16

benjamin-kroeger opened this issue Dec 7, 2024 · 1 comment

Comments

@benjamin-kroeger
Copy link

benjamin-kroeger commented Dec 7, 2024

Hey thanks for building this framework it is exactly what I need for my project but I was wondering, whether there is a particular reason for why flash attention 2 and rotary positional embeddings were discarded from the standard Llama implementation?

@SeanLee97
Copy link
Contributor

hi @benjamin-kroeger, it might be because this code is based on an earlier transformers version. I will upgrade it to be compatible with the latest transformers when I am free. PRs are also welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants