Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement to setuptools installable package #53

Open
dspruell-s01 opened this issue Oct 12, 2020 · 3 comments
Open

Implement to setuptools installable package #53

dspruell-s01 opened this issue Oct 12, 2020 · 3 comments

Comments

@dspruell-s01
Copy link

Would be great to have tls_prober be installable from PyPI, via pip, in virtualenv with ease, etc.

https://packaging.python.org/tutorials/packaging-projects/

@tomato42
Copy link
Collaborator

  1. location of fingerprints would have to be abstracted
  2. generation of new ones -a option would nee to create them in a current working directory, /tmp, or someplace similar

@dspruell-s01
Copy link
Author

If I'm not mistaken fingerprints can be included in the package and access abstracted using the ResourceManager API in setuptools as mentioned here: https://setuptools.readthedocs.io/en/latest/userguide/datafiles.html#accessing-data-files-at-runtime

Regarding -a, could maybe see having a system database (installed with the package, read-only) and a user database (in XDG_DATA_HOME or a path from env var) that is modifiable, and having those merged at runtime or something.

@tomato42
Copy link
Collaborator

sounds good, feel free to propose a PR with this

maybe split it up to two PRs to make review a bit easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants