Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions and comments #8

Open
DonorKrovi opened this issue Sep 20, 2023 · 16 comments
Open

Suggestions and comments #8

DonorKrovi opened this issue Sep 20, 2023 · 16 comments

Comments

@DonorKrovi
Copy link

As far as I understand, the player immediately receives a global chat when connecting to the world, but there is no notification about an active global chat such as in local, there is no bossbar at the bossbar level, which is strange, in addition, I would suggest making a CD to demonstrate the chat message, after the change the message should disappear after 1-2 minutes because sometimes it is annoying

I propose to add a notification that there are no other players next to the player who is in the local channel, you also need to take into account that players in gm3 will not be taken into account in this case

there is no line in the config that would be responsible for the Global chat

@Wesley1808
Copy link
Owner

As far as I understand, the player immediately receives a global chat when connecting to the world, but there is no notification about an active global chat such as in local, there is no bossbar at the bossbar level, which is strange

there is no line in the config that would be responsible for the Global chat

The reason for that is mostly because global chat is treated as an "unmodified" / default chat channel, like as in vanilla.
The chat channel the player is in for global chat is in the quite literal sense null. I can probably add notifications to it, but the main reason I didn't is because I personally don't really like any of the serverside options to show which channel you're in, and since its basically default anyway.

I propose to add a notification that there are no other players next to the player who is in the local channel, you also need to take into account that players in gm3 will not be taken into account in this case

What could be done here is to notify the player when nobody in that channel received a message.
Technically this is kind of already in place, if you hover over the channel tag - like [Local] - it will show you the names of the players who received the message (spectator and vanished players excluded).

@DonorKrovi
Copy link
Author

I tried to silence the local chat, but when I log into the server, the players still have a global one, do you have such a problem?

@Wesley1808
Copy link
Owner

I'm not sure what you mean. How did you try to silence local chat and why is that supposed to affect how global chat works?

@DonorKrovi
Copy link
Author

I'm not sure what you mean. How did you try to silence local chat and why is that supposed to affect how global chat works?

Sorry, I used a translator, I wanted to use the default local chat as soon as the players connected, they immediately received a local chat, but for some reason I always got a global channel when I logged in

@Wesley1808
Copy link
Owner

By default for the first time you log in you will be in global chat, unless you automatically change it for each player individually, like for example by using /execute as <player> run chat local when they first join.

This can then be changed by the player to any channel they have access to (and global since its not actually a channel) with /chat <channel>.

AdvancedChat does store which channel you logged out with though, so if you logged out in local chat you will join back in local chat.

@DonorKrovi
Copy link
Author

And how do you like the idea of adding the ability to set text colors for the chat by default? For example, /text blue would make the player's chat a different color

@Wesley1808
Copy link
Owner

Wesley1808 commented Sep 22, 2023

I'm not sure what the idea is - if you just mean that each player can set their default text color individually, thats a bit out of scope for this project. AdvancedChat doesn't really do anything with chat message formatting either, that is far better handled by StyledChat.

Now lets say for example you want have specific chat formatting based on the channel you're currently in, you could use styledchat's permission styles to do that.

Starting with commit 0af2ce7 you'd be able to for example do this (styledchat config), which would make global chat text default red and local default blue.

  "styles": [
    {
      "require": {
        "type": "advancedchat:channel",
        "channel": "local"
      },
      "message_formats": {
        "chat": "%advancedchat:channelprefix%${player} <dark_gray>»</dark_gray> <blue>${message}"
      },
      "formatting": {},
      "emoticons": {},
      "custom_message_types": {}
    },
    {
      "require": {
        "type": "advancedchat:channel",
        "channel": "global"
      },
      "message_formats": {
        "chat": "%advancedchat:channelprefix%${player} <dark_gray>»</dark_gray> <red>${message}"
      },
      "formatting": {},
      "emoticons": {},
      "custom_message_types": {}
    }
  ]

@DonorKrovi
Copy link
Author

I'm not sure what the idea is - if you just mean that each player can set their default text color individually, thats a bit out of scope for this project. AdvancedChat doesn't really do anything with chat message formatting either, that is far better handled by StyledChat.

Now lets say for example you want have specific chat formatting based on the channel you're currently in, you could use styledchat's permission styles to do that.

Starting with commit 0af2ce7 you'd be able to for example do this (styledchat config), which would make global chat text default red and local default blue.

  "styles": [
    {
      "require": {
        "type": "advancedchat:channel",
        "channel": "local"
      },
      "message_formats": {
        "chat": "%advancedchat:channelprefix%${player} <dark_gray>»</dark_gray> <blue>${message}"
      },
      "formatting": {},
      "emoticons": {},
      "custom_message_types": {}
    },
    {
      "require": {
        "type": "advancedchat:channel",
        "channel": "global"
      },
      "message_formats": {
        "chat": "%advancedchat:channelprefix%${player} <dark_gray>»</dark_gray> <red>${message}"
      },
      "formatting": {},
      "emoticons": {},
      "custom_message_types": {}
    }
  ]

You can release at 1 20 1

@DonorKrovi
Copy link
Author

?

@Wesley1808
Copy link
Owner

@DonorKrovi
Copy link
Author

3ffe330 - Github Actions Download

Thanks!

@DonorKrovi
Copy link
Author

DonorKrovi commented Sep 26, 2023

I'm not sure what the idea is - if you just mean that each player can set their default text color individually, thats a bit out of scope for this project. AdvancedChat doesn't really do anything with chat message formatting either, that is far better handled by StyledChat.

Now lets say for example you want have specific chat formatting based on the channel you're currently in, you could use styledchat's permission styles to do that.

Starting with commit 0af2ce7 you'd be able to for example do this (styledchat config), which would make global chat text default red and local default blue.

  "styles": [
    {
      "require": {
        "type": "advancedchat:channel",
        "channel": "local"
      },
      "message_formats": {
        "chat": "%advancedchat:channelprefix%${player} <dark_gray>»</dark_gray> <blue>${message}"
      },
      "formatting": {},
      "emoticons": {},
      "custom_message_types": {}
    },
    {
      "require": {
        "type": "advancedchat:channel",
        "channel": "global"
      },
      "message_formats": {
        "chat": "%advancedchat:channelprefix%${player} <dark_gray>»</dark_gray> <red>${message}"
      },
      "formatting": {},
      "emoticons": {},
      "custom_message_types": {}
    }
  ]

I'm using version 1.20.1 and noticed that for some reason you can't use a prefix for the global channel, is that how it should be?

it doesn't work at all for me

{
"CONFIG_VERSION_DONT_TOUCH_THIS": 3,
"comment": "Before changing anything, see https://github.com/Patbox/StyledChat#configuration",
"text_formatting": {
"legacy_formatting": false,
"parse_links": true,
"parse_mentions": false,
"markdown": true,
"respect_colors_client_setting": true
},
"auto_completion": {
"tags": false,
"tag_aliases": false,
"emoticons": false
},
"default": {
"display_name": "${default}",
"message_formats": {
"chat": "%luckperms:prefix% ${player}: ${message}",
"joined_the_game": "<#22DB60>К нам подключается игрок: ${player} <#1ED25A>Фракция: <#98CB1F>%factions:name%",
"joined_after_name_change": "lang:multiplayer.player.joined.renamed:'${player}':'${old_name}'",
"joined_for_first_time": "<#41D096>Новый игрок подключился на сервер: ${player}",
"left_game": "Игрок: ${player} <#3BD4BA>Покинул игру",
"base_death": "<#DB5A22>${default_message}",
"advancement_task": "<#D618E4>Игрок: ${player} Получил новое достижение: ${advancement}",
"advancement_challenge": "lang:chat.type.advancement.challenge:'${player}':'${advancement}'",
"advancement_goal": "lang:chat.type.advancement.goal:'${player}':'${advancement}'",
"sent_team_chat": "<lang:'chat.type.team.sent':'<hover\:\'<lang\:chat.type.team.hover>\'><suggest_command\:\'/teammsg \'>${team}':'${displayName}':'${message}'>",
"received_team_chat": "<lang:'chat.type.team.text':'<hover\:\'<lang\:chat.type.team.hover>\'><suggest_command\:\'/teammsg \'>${team}':'${displayName}':'${message}'>",
"sent_private_message": "<#7D3BD4>Вы отправили сообщение игроку: <#59CD1F>${receiver}: ${message}",
"received_private_message": "<#7D3BD4>Пришло письмо на имя: <#59CD1F>${receiver}: ${message}",
"say_command": "<#F30C0C>[ОБЪЯВЛЕНИЕ] <#CDB61F>[${player}]: <#38AE2F>${message}",
"me_command": "lang:'chat.type.emote':'${player}':'${message}'",
"pet_death": "<#41263B>${default_message}"
},
"link_style": "<c:#7878ff>${link}",
"mention_style": "<c:#7878ff>%player:displayname%",
"spoiler_style": "${spoiler}",
"spoiler_symbol": "▌",
"formatting": {
"dark_red": true,
"green": true,
"underline": true,
"dark_green": true,
"black": true,
"yellow": true,
"bold": true,
"italic": true,
"dark_blue": true,
"dark_purple": true,
"gold": true,
"red": true,
"aqua": true,
"gray": true,
"light_purple": true,
"blue": true,
"white": true,
"dark_aqua": true,
"dark_gray": true,
"spoiler": true,
"strikethrough": true
},
"emoticons": {
"$emojibase:builtin:joypixels": "${emoji}",
"shrug": "¯\
(ツ)_/¯",
"table": "(╯°□°)╯︵ ┻━┻",
"sword": "🗡",
"bow": "🏹",
"trident": "🔱",
"rod": "🎣",
"potion": "🧪",
"shears": "✂",
"bucket": "🪣",
"bell": "🔔",
"item": "[%player:equipment_slot mainhand%]",
"pos": "%player:pos_x% %player:pos_y% %player:pos_z%"
},
"custom_message_types": {}
},
"styles": [
{
"require": {
"type": "advancedchat:channel",
"channel": "local"
},
"message_formats": {
"chat": "%advancedchat:channelprefix%${player} <dark_gray>»</dark_gray> <#B9DB48>${message}"
},
"formatting": {},
"emoticons": {},
"custom_message_types": {}
},
{
"require": {
"type": "advancedchat:channel",
"channel": "global"
},
"message_formats": {
"chat": "%advancedchat:channelprefix%${player} <dark_gray>»</dark_gray> <#B9DB48>${message}"
},
"formatting": {},
"emoticons": {},
"custom_message_types": {}
},
{
"require": {
"type": "advancedchat:channel",
"channel": "admin"
},
"message_formats": {
"chat": "%advancedchat:channelprefix%${player} <dark_gray>»</dark_gray> ${message}"
},
"formatting": {},
"emoticons": {},
"custom_message_types": {}
}
]
}

@DonorKrovi
Copy link
Author

image

local and admin work

@Wesley1808
Copy link
Owner

What does your advancedchat config look like?
It worked fine when I tested it.

@DonorKrovi
Copy link
Author

What does your advancedchat config look like? It worked fine when I tested it.

https://mclo.gs/Vqs90ea

@Wesley1808
Copy link
Owner

If I had to guess its because it doesn't expect you to try and override the global chat channel like that.
Alternatively in your case you could just add the color to the "default" style in the styledchat config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants