Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: basic protection boot endpoint #334

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Dec 9, 2024

This PR implements a basic protection of the boot endpoint, this enables you to more easily deploy test instances publicly. This way you can add the authorization to the URL. See rationale in #327

Closes #327

If we also land #333, I will rebase this on top and also expose this feature as command line flags.

I also thought this could be implemented as a falcon middleware. But wanted to get feedback first whether or not it should be included at all.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 98.59155% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.86%. Comparing base (18d3ad7) to head (b553064).
Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
src/keria/app/agenting.py 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
+ Coverage   93.06%   93.86%   +0.79%     
==========================================
  Files          36       36              
  Lines        7121     8147    +1026     
==========================================
+ Hits         6627     7647    +1020     
- Misses        494      500       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenkan lenkan requested review from 2byrds and iFergal December 9, 2024 14:59
src/keria/app/agenting.py Show resolved Hide resolved
src/keria/app/cli/commands/start.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lenkan lenkan force-pushed the feat-boot-protection branch from 8610df9 to fe75188 Compare December 10, 2024 15:01
@lenkan lenkan merged commit 4981d84 into WebOfTrust:main Dec 11, 2024
5 checks passed
@lenkan lenkan deleted the feat-boot-protection branch December 11, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to protect the boot endpoint
3 participants