Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure keria with environment variables #333

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Dec 9, 2024

  • Move all access to os.getenv to start.py to make it easier to get an overview of what environment variables are available.
    • Previous ones were KERI_AGENT_CORS and KERIA_RELEASER_TIMEOUT
  • Added KERIA_CURLS which is the endpoint for the "KERI port". Since this is dependent on the deployment, it is convenient to be able to configure this with an environment variable.
  • Added KERIA_DURLS and KERIA_IURLS, to be able to configure "default" witnesses and data urls for agents.
  • Removed the default docker entrypoint that sets up "demo-witness-oobis". From what I could see, this file is not copied into the image anyway.

Closes #326

@lenkan lenkan force-pushed the feat-configuration-env-variables branch from c7a9b04 to 53757b6 Compare December 9, 2024 14:10
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 98.36066% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.82%. Comparing base (18d3ad7) to head (53757b6).
Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
src/keria/app/agenting.py 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   93.06%   93.82%   +0.75%     
==========================================
  Files          36       36              
  Lines        7121     8076     +955     
==========================================
+ Hits         6627     7577     +950     
- Misses        494      499       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@iFergal iFergal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenkan lenkan merged commit 912e681 into WebOfTrust:main Dec 10, 2024
5 checks passed
@lenkan lenkan deleted the feat-configuration-env-variables branch December 10, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to configure keria through environment variables
3 participants