Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete/remove credential endpoint #330

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

iFergal
Copy link
Collaborator

@iFergal iFergal commented Dec 6, 2024

Resolves #79. DELETE /credentials/{said} - it will remove the credential from the DB and any associated indices.

This is different to revoke, which is under DELETE /identifiers/{name}/credentials/{said} (the path used for issuance).

@iFergal iFergal requested a review from 2byrds December 6, 2024 18:20
@iFergal iFergal self-assigned this Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (18d3ad7) to head (7b18cba).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
+ Coverage   93.06%   93.78%   +0.72%     
==========================================
  Files          36       36              
  Lines        7121     8030     +909     
==========================================
+ Hits         6627     7531     +904     
- Misses        494      499       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2byrds 2byrds merged commit 9107d02 into WebOfTrust:main Dec 6, 2024
5 checks passed
@iFergal iFergal deleted the feat/deleteCredentials branch December 9, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method to delete credentials from db
3 participants