Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 404s and mismatching resource types #31

Open
Treora opened this issue Aug 7, 2018 · 1 comment
Open

Handle 404s and mismatching resource types #31

Treora opened this issue Aug 7, 2018 · 1 comment
Labels
snapshot quality Improving fidelity/size/durability/etc of the output

Comments

@Treora
Copy link
Contributor

Treora commented Aug 7, 2018

For example, we currently happily inline an html 404 page as if it was the desired resource, producing e.g. <img src="data:text/html;base64,......">. We could consider alternatives, such as replacing such URLs with about:invalid.

@Treora Treora mentioned this issue Aug 7, 2018
@Treora Treora added the snapshot quality Improving fidelity/size/durability/etc of the output label Apr 6, 2019
@Treora
Copy link
Contributor Author

Treora commented Jun 26, 2019

I just noticed that when fetching a stylesheet results in an html error page, styles declared inside that page (inside a <style> tag) may actually be interpreted and applied by the browser (observed in Firefox and Chromium). Reminds of #17 (even though this does not corrupt the HTML itself, it does corrupt the applied styles).

This needs fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
snapshot quality Improving fidelity/size/durability/etc of the output
Projects
None yet
Development

No branches or pull requests

1 participant