Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline iframe contents #3

Closed
Treora opened this issue Jul 19, 2017 · 6 comments
Closed

Inline iframe contents #3

Treora opened this issue Jul 19, 2017 · 6 comments

Comments

@Treora
Copy link
Contributor

Treora commented Jul 19, 2017

Freeze-dry could be run recursively on iframes. Iframe contents can probably be put as a string in the srcdoc attribute.

Although deprecated, it would be nice to still support <frame>s too; they don't support srcdoc though, so we should try putting contents as a data URL in the src attribute.

@erikrose
Copy link

erikrose commented Dec 8, 2017

I'm moderately interested in having this happen. Talking with Ian Bicking, who has a similar project, he mentioned that there are webext permission issues around getting ahold of (in particular) the CSS of iframes but that using a framescript might avail. I mention this to save time for anybody who pursues this.

@Treora
Copy link
Contributor Author

Treora commented Dec 9, 2017 via email

@erikrose
Copy link

I think one of the things he was proudest of is his spidering of CSS @import statements. But that's just from my fuzzy recollection.

@Treora
Copy link
Contributor Author

Treora commented Jul 20, 2018

Implemented in 0.2.0. :)

Still need to allow browser extensions etcetera to customise how the iframe contents are captured, for in case direct access to .contentDocument is prohibited (by the single origin policy). In any case, it now falls back to refetching the iframe's source html and using that instead of the currently rendered iframe content. (edit: see #24)

@Treora Treora closed this as completed Jul 20, 2018
@erikrose
Copy link

Hooray! This is a great step forward, and I'll soon update FathomFox's version of freeze-dry to enjoy it. :-D

@erikrose
Copy link

I don't seem to actually get inlined iframe contents in 0.2.0. Instead, I get src= some external server, like this:

<iframe style="border: 0px none; vertical-align: bottom;" src="https://tpc.googlesyndication.com/safeframe/1-0-29/html/container.html" id="google_ads_iframe_/74268401/UG_ATF_728_0" title="3rd party ad content" name="" scrolling="no" marginwidth="0" marginheight="0" data-is-safeframe="true" sandbox="allow-forms allow-pointer-lock allow-popups allow-popups-to-escape-sandbox allow-same-origin allow-scripts allow-top-navigation-by-user-activation" width="728" height="90" frameborder="0">

(The source page for the above was https://tabs.ultimate-guitar.com/tab/johann_sebastian_bach/sleepers_awake_tabs_877865.) Do you have any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants