Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.3] pass request-options to outgoing-handler by borrow #136

Open
pchickey opened this issue Nov 20, 2024 · 0 comments
Open

[v0.3] pass request-options to outgoing-handler by borrow #136

pchickey opened this issue Nov 20, 2024 · 0 comments

Comments

@pchickey
Copy link
Contributor

pchickey commented Nov 20, 2024

In 0.2, outgoing-handler gets passed an option<request-options>:

  @since(version = 0.2.0)
  handle: func(
    request: outgoing-request,
    options: option<request-options>
  ) -> result<future-incoming-response, error-code>;

It would be nice if this was instead an option<borrow<request-options>> so that the same options could be reused across many requests.

We can't change this in 0.2 because it would be a breaking change, but we should take the opportunity to fix it in 0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant