Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valuable Prisoner Taken toast description not stating name of prisoner in localization #1547

Open
Rimaka94 opened this issue Oct 24, 2024 · 0 comments
Labels
bug 🐛 This issue reports a bug localisation 📄 This issue or pull request supposes localization changes priority low ❕ Shows priority

Comments

@Rimaka94
Copy link
Contributor

Issue Description:
This may possibly be an issue with a base game file. When the Valuable Prisoner Taken toast pops up, the name of the prisoner being taken is empty in the toast.

siege.1006.pow_toast.desc:2 "[occupant.GetTitledFirstName] took [valuable_prisoner.Custom2('MyCharacterIntroduction', ROOT.Char)] prisoner after the Siege of [barony.GetNameNoTier]"

game>localization>english>event_localization>war_event>siege_events_l_english.yml

How To Reproduce:
Go to war with someone (preferably a much larger target) and allow them to siege your capital until siege.1006.pow_toast.t:2 "Valuable Prisoner Taken" toast pops up, as can be seen in screenshot. If incorrect, this will not state the name of the prisoner that was taken, but correctly display their character to the right of the toast.

I can reproduce this as a Pygmy in Uldum as well as the Murloc ruler of Stonecairn next to Stormwind.

Screenshots:
image
image

Game Files:

@Rimaka94 Rimaka94 added priority low ❕ Shows priority localisation 📄 This issue or pull request supposes localization changes bug 🐛 This issue reports a bug labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 This issue reports a bug localisation 📄 This issue or pull request supposes localization changes priority low ❕ Shows priority
Projects
None yet
Development

No branches or pull requests

1 participant