feat: decrypted notifications analytics #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris13524
changed the title
geekbrother
approved these changes
Nov 20, 2023
| pub flags: u32, | ||
| pub always_raw: Option<bool>, | ||
| pub tag: Option<u32>, | ||
| pub encrypted: Option<bool>, |
There was a problem hiding this comment.
Non-blocking. It's a bit confusing to have always_raw and encrypted. The value from encrypted comes from body.legacy maybe we should use legacy_encrypted? So it will not confuse the data team as well.
There was a problem hiding this comment.
We can't change the scheme since there is already data that's been exported using it. We'd have to wipe the data or adjust queries to exclude the old schema, which can be done but in this case doesn't seem necessary
geekbrother
merged commit d1d4823
into
feat/decrypted_notifs/update_message_payload_and_pass_raw
6 checks passed
geekbrother
pushed a commit
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
always_rawfield to client info export, set to the value the client provided.Adds
always_rawto message export, which is set to the same value of the client, or null if the client cannot be found.Makes
encryptedandflagsoptional, since these are optionally provided from the relay now.Adds
tagfield which is provided by the relay, and is technically optional during initial rollout.Resolves #282
How Has This Been Tested?
Not tested
Due Diligence