Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(decrypted_notify): adding always_raw for the client registration #279

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

geekbrother
Copy link
Contributor

@geekbrother geekbrother commented Nov 14, 2023

Description

This PR adds always_raw field to the clients database table and to the client register endpoint as an optional field with the false as default to follow the specs for the decrypted notifications.

Related to #278

How Has This Been Tested?

Updated functional tests.

Review stack 🏗️

1 - Adding always_raw for the client registration #279 <-
2 - Update message payload and pass raw message #281

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Nov 14, 2023
@arein arein added the accepted The issue has been accepted into the project label Nov 14, 2023
@geekbrother geekbrother force-pushed the feat/decrypted_notifs/add_always_raw_to_register branch 2 times, most recently from e546cb4 to b00491c Compare November 14, 2023 20:42
@geekbrother geekbrother force-pushed the feat/decrypted_notifs/add_always_raw_to_register branch from fa9b0b9 to 8269b2c Compare November 16, 2023 22:49
@chris13524
Copy link
Member

chris13524 commented Nov 16, 2023

Created: #282

@geekbrother geekbrother force-pushed the feat/decrypted_notifs/add_always_raw_to_register branch from 8269b2c to ed6a83e Compare November 16, 2023 23:24
@geekbrother geekbrother marked this pull request as ready for review November 17, 2023 00:48
@chris13524 chris13524 requested a review from xav November 17, 2023 01:07
@geekbrother geekbrother merged commit 16a377a into main Nov 21, 2023
6 checks passed
@geekbrother geekbrother deleted the feat/decrypted_notifs/add_always_raw_to_register branch November 21, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted The issue has been accepted into the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants