Port old tests

[brianbunke]

As @boyler05 pointed out in #91, we never got around to porting all of the old tests into the new format. I'd prefer others work on this, so I'm labeling it up for grabs. If you're interested, please speak up and I'll assign. (Random GitHub question: Can people w/o write access to the project self-assign issues?)

Happy to answer any questions and provide guidance if needed.

EDIT: This needs more info.

Here's a snapshot of the repo in the old test format: https://github.com/WahlNetwork/Vester/tree/47f400a76738d28308881f0573526ebc14f3885e

I believe all the tests pointed out existed at that time. You would need to:

• Find a test file that hasn't been ported yet
• Determine how many tests exist inside that file
  • Right now, test files are meant to test just one thing, but they could perform multiple checks at that point
• Review Config.ps1 (for at least the $Desired value) and Config.Tests.ps1 (for at least the $Description) to grab related values
• Copy an existing .Vester.ps1 file and update the variables
• Drop it in the test folder matching the test's scope

At this point, we generally name tests "Category-Specific.Vester.ps1". We haven't implemented anything that cares about that right now, but it's a decent way to group tests together, especially during a Get-ChildItem.

[michaeltlombardi]

People without write access do not seem to be able to self-assign issues.

[haberstrohr]

I went through the old tests (thanks @brianbunke for the link!) and created the following table to help focus on what tests are remaining. I'll continue to update the table as more tests are added, noting what changes are made. This list includes the Task and Event tests created by @jeffgreenca in #106. If there are any I missed from the old or missed new additions please let me know and I'll update.

• SMTP Tests submitted in vCenter SMTP tests #108
  • Updated table

Test Type	Name	In Current Build
CLUSTER	DRS Enabled	Yes
CLUSTER	DRS Mode	Yes
CLUSTER	DRS Automation Level	Yes
CLUSTER	HA State	Yes
HOST	DNS server addresses	Yes
HOST	DNS Search Domain	Yes
HOST	Net Dump Configuration - Enabled	No
HOST	Net Dump Configuration - Settings	No
HOST	NFS Advanced Configuration	No
HOST	NTP Servers	Yes
HOST	SSH Service State	Yes
HOST	SSH Warning State	Yes
HOST	SSH Timeout	Yes
HOST	SSH Interactive Timeout	Yes
HOST	Syslog Service State	Yes
HOST	Syslog Firewall State	Yes
Network	VDS Link Protocol	Yes
Network	VDS Link Operation	No
Network	VDS MTU Size	No
vCenter	Event Max Age	Yes
vCenter	Event Max Age Enabled	Yes
vCenter	Task Max Age	Yes
vCenter	Task Max Age Enabled	Yes
vCenter	SMTP Sender	Yes
vCenter	SMTP Port	Yes
vCenter	SMTP Server	Yes
VM	Boot Delay	No
VM	Sync Time Settings	No
VM	Snapshot Retentions (in days)	No
VM	CPU limits	Yes
VM	Memory limits	Yes
VM	CPU reservation	No
VM	Memory reservation	No
VM	Allow Connected CDROM	Yes

[exablaze]

I'll take the two Net Dump Configuration items if they're still unclaimed.

[midacts]

I think i should be able to knock out most of these except for the Network scope.
I should also be able to do the Network scope tests, i just plan on doing those last.

[midacts]

I'll work on the VM snapshot test next.
Then the Network tests.
Then the Host NFS test. I looked at this one already. I am probably going to have to talk with Brian about this one.

[haberstrohr]

That's awesome, thanks. Plan on taking some tests on myself once I get back to a more regular routine. This is more of a reminder to myself, but reference this issue in your PR when submitted.

[ghost]

Going through the table posted by @haberstrohr I believe all of these tests have been ported. Can someone confirm?

[midacts]

Host: NFS Advanced Config?