Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timings - high count for PlayerJoinEvent #93

Open
WizardCM opened this issue Jul 26, 2013 · 1 comment
Open

Timings - high count for PlayerJoinEvent #93

WizardCM opened this issue Jul 26, 2013 · 1 comment
Labels
Enhancement Major [Mode] ALL
Milestone
1.2

Comments

@WizardCM
Copy link
Member

26-07_20-23-47

More details: http://aikar.co/timings.php?url=5906185
@WizardCM
Copy link
Member Author

It has been determined this is caused by host lookups. My idea for a fix is to check the IP and compare it to a past IP, and if it matches then simply use the old host.

Alternatively, the entire task can be delayed and wait for the asynchronous host lookup, and instead join the user to IRC a little later.

Also - we can add a config option that disables the host lookup in general, for those who don't want it.

Current dev build has it disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Major [Mode] ALL
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
1 participant
@WizardCM