From 5e3091eabc1d002d2ae35793837b5d85e8bd05bb Mon Sep 17 00:00:00 2001
From: qingxinwu <6334674+qingxinwu@users.noreply.github.com>
Date: Sun, 1 Dec 2024 17:31:31 -0500
Subject: [PATCH] [Spec] Explicitly set service worker mode to none

Set requests' service worker mode to null,  instead of using a note to explain the service working mode being null when client is set to null
---
 spec.bs | 54 ++++++++++++++++++++++++------------------------------
 1 file changed, 24 insertions(+), 30 deletions(-)

diff --git a/spec.bs b/spec.bs
index 5b77ccafd..228fb3882 100644
--- a/spec.bs
+++ b/spec.bs
@@ -2591,18 +2591,17 @@ To <dfn>fetch WebAssembly</dfn> given a [=URL=] |url| and an [=environment setti
     :   [=request/mode=]
     ::  "`no-cors`"
     :   [=request/referrer=]
-    :: "`no-referrer`"
+    ::  "`no-referrer`"
     :   [=request/credentials mode=]
     ::  "`omit`"
     :   [=request/redirect mode=]
-    :: "`error`"
+    ::  "`error`"
+    :   [=request/service-workers mode=]
+    ::  "`none`"
     :   [=request/policy container=]
     ::  A new [=policy container=] whose [=policy container/IP address space=] is |settings|'s
       [=environment settings object/policy container=]'s [=policy container/IP address space=]
 
-    Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
-    service worker interceptions, despite not having to set the service workers mode.
-
     Issue: Stop using "`no-cors`" mode where possible
     (<a href="https://github.com/WICG/turtledove/issues/667">WICG/turtledove#667</a>).
   1. Let |moduleObject| be null.
@@ -2638,18 +2637,17 @@ To <dfn>fetch trusted signals</dfn> given a [=URL=] |url|, an [=origin=] |script
     :   [=request/mode=]
     ::  "`cors`"
     :   [=request/referrer=]
-    :: "`no-referrer`"
+    ::  "`no-referrer`"
     :   [=request/credentials mode=]
     ::  "`omit`"
     :   [=request/redirect mode=]
-    :: "`error`"
+    ::  "`error`"
+    :   [=request/service-workers mode=]
+    ::  "`none`"
     :   [=request/policy container=]
     ::  A new [=policy container=] whose [=policy container/IP address space=] is |policyContainer|'s
       [=policy container/IP address space=]
 
-    Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
-    service worker interceptions, despite not having to set the service workers mode.
-
   1. Let |signals| be null.
   1. Let |dataVersion| be null.
   1. Let |formatVersion| be null.
@@ -2763,18 +2761,17 @@ To <dfn>send report</dfn> given a [=URL=] |url|, and an [=environment settings o
     :   [=request/mode=]
     ::  "`no-cors`"
     :   [=request/referrer=]
-    :: "`no-referrer`"
+    ::  "`no-referrer`"
     :   [=request/credentials mode=]
     ::  "`omit`"
     :   [=request/redirect mode=]
-    :: "`error`"
+    ::  "`error`"
+    :   [=request/service-workers mode=]
+    ::  "`none`"
     :   [=request/policy container=]
     ::  A new [=policy container=] whose [=policy container/IP address space=] is |settings|'s
       [=environment settings object/policy container=]'s [=policy container/IP address space=]
 
-    Issue: One of the side-effects of a `null` client for this subresource request is it neuters
-    all service worker interceptions, despite not having to set the service workers mode.
-
     Issue: Stop using "`no-cors`" mode where possible
     (<a href="https://github.com/WICG/turtledove/issues/667">WICG/turtledove#667</a>).
   1. [=Fetch=] |request| with [=fetch/useParallelQueue=] set to true.
@@ -4068,18 +4065,17 @@ Initial implementation of this specification defines
     :   [=request/mode=]
     ::  "`no-cors`"
     :   [=request/referrer=]
-    :: "`no-referrer`"
+    ::  "`no-referrer`"
     :   [=request/credentials mode=]
     ::  "`omit`"
     :   [=request/redirect mode=]
-    :: "`error`"
+    ::  "`error`"
+    :   [=request/service-workers mode=]
+    ::  "`none`"
     :   [=request/policy container=]
     ::  A new [=policy container=] whose [=policy container/IP address space=] is |settings|'s
       [=environment settings object/policy container=]'s [=policy container/IP address space=]
 
-    Issue: One of the side-effects of a `null` client for this subresource request is it neuters
-    all service worker interceptions, despite not having to set the service workers mode.
-
     Issue: Stop using "`no-cors`" mode where possible
     (<a href="https://github.com/WICG/turtledove/issues/667">WICG/turtledove#667</a>).
   1. [=Fetch=] |request| with [=fetch/useParallelQueue=] set to true.
@@ -6528,18 +6524,17 @@ navigating to another page. Some implementations, such as Chromium, have chosen
       :   [=request/mode=]
       ::  "`no-cors`"
       :   [=request/referrer=]
-      :: "`no-referrer`"
+      ::  "`no-referrer`"
       :   [=request/credentials mode=]
       ::  "`omit`"
       :   [=request/redirect mode=]
-      :: "`error`"
+      ::  "`error`"
+      :   [=request/service-workers mode=]
+      ::  "`none`"
       :   [=request/policy container=]
       ::  A new [=policy container=] whose [=policy container/IP address space=] is |policyContainer|'s
         [=policy container/IP address space=]
 
-      Issue: One of the side-effects of a `null` client for this subresource request is it neuters
-      all service worker interceptions, despite not having to set the service workers mode.
-
       Issue: Stop using "`no-cors`" mode where possible
       (<a href="https://github.com/WICG/turtledove/issues/667">WICG/turtledove#667</a>).
     1. Let |update| be null.
@@ -7080,11 +7075,11 @@ To <dfn>check interest group permissions</dfn> given an [=origin=] |ownerOrigin|
   :   [=request/mode=]
   ::  "`cors`"
   :   [=request/referrer=]
-  :: "`no-referrer`"
+  ::  "`no-referrer`"
   :   [=request/credentials mode=]
   ::  "`omit`"
   :   [=request/redirect mode=]
-  :: "`error`"
+  ::  "`error`"
   :   [=request/service-workers mode=]
   ::  `none`
   :   [=request/policy container=]
@@ -8239,13 +8234,12 @@ a [=script fetcher=] |fetcher|:
     ::  "`omit`"
     :   [=request/redirect mode=]
     ::  "`error`"
+    :   [=request/service-workers mode=]
+    ::  "`none`"
     :   [=request/policy container=]
     ::  A new [=policy container=] whose [=policy container/IP address space=] is |settings|'s
       [=environment settings object/policy container=]'s [=policy container/IP address space=]
 
-    Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
-    service worker interceptions, despite not having to set the service workers mode.
-
     Issue: Stop using "`no-cors`" mode where possible
     (<a href="https://github.com/WICG/turtledove/issues/667">WICG/turtledove#667</a>).