Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first pass QC of underway data #29

Open
ecrockford opened this issue Mar 30, 2021 · 8 comments
Open

first pass QC of underway data #29

ecrockford opened this issue Mar 30, 2021 · 8 comments
Assignees
Labels
discussion issue primarily serves as a discussion forum

Comments

@ecrockford
Copy link

Establish some simple filters to pass over underway data for rough QC prior to uploading to the API.

Output NA for skipped data.
When looking at max/min values use some sort of rolling average or rolling median?
If 1 parameter is bad, do we mask out all parameters? Do we group TSG together and any others separate?

Possible filters:

  • minimum salinity value
  • minimum flow meter value (Armstrong)
  • maximum fluorometer reading
  • Temperature.... extreme max and min?
@joefutrelle
Copy link
Contributor

Locate column header for flow meter for different cruises.

@sbeaulieu
Copy link
Collaborator

Column header for salinity: SBE45S. Column header for flow meter: FLOW. A challenge with flow meter is that the average value (in ml/s) differs between cruises (e.g., ~50, ~80, ~130 depending on cruise). I saw zero values in several, and NAN values in some. Let's discuss with Taylor re: thresholds for minimum salinity and flow meter values.

@ecrockford
Copy link
Author

Yes thanks for pointing that out Stace. A while ago Joe and I discussed this. We thought maybe a running average with significant deviation from that average could work? Something along those lines. I've heard in passing from the ship's techs that the flow meter isn't super great so we should take values with a grain of salt. Basically, looking for deviations from consistency.

@sbeaulieu sbeaulieu assigned ecrockford and joefutrelle and unassigned sbeaulieu Apr 15, 2021
@sbeaulieu
Copy link
Collaborator

Noting that in today's Zoom we discussed providing a quality flag column for each of these: salinity, flow meter, and fluorometer. We also discussed providing a comments column that would be auto-populated to alert the end user that a flag(s) was applied.

@joefutrelle
Copy link
Contributor

joefutrelle commented Apr 22, 2021

Endeavor data does not use the column headers specified here, so the API will need to skip adding quality flags for that data.

Once column names are regularized, this will not require per-cruise or per-vessel configurations (although regularization will).

@joefutrelle
Copy link
Contributor

Related to #30

@sbeaulieu
Copy link
Collaborator

develop QA/QC checks using Armstrong data and evaluate with Taylor

@joefutrelle joefutrelle modified the milestones: REST api enhancements, Year 4 report May 27, 2021
@joefutrelle
Copy link
Contributor

From the original description:

Establish some simple filters to pass over underway data for rough QC prior to uploading to the API.

If these tools are not part of the REST API then we should consider tracking this work elsewhere. I'm leaving the issue open for now but addressing it may not touch this codebase.

@joefutrelle joefutrelle added the discussion issue primarily serves as a discussion forum label Mar 28, 2023
@joefutrelle joefutrelle removed this from the enhancements to be completed ahead of mid-term review milestone Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion issue primarily serves as a discussion forum
Projects
None yet
Development

No branches or pull requests

3 participants