-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check that all SPARQL queries have been converted to externalized query format #1284
Comments
Also check for queries that are commented out, as per #1170 . |
Another thing to check here is that all queries have a proper HTML section ID, as per #1093 . |
With the above merged PRs, @curibe can this be closed? |
I suppose. Do we have a "grep" that can check? |
Not sure if this is thorough but: /scholia/scholia/app/templates$ grep SELECT *.html
base.html: SELECT DISTINCT ?aspect
base.html: SELECT DISTINCT ?aspectsubpage |
In the sidebar, click "Unpin issue" 👍 I thought it would do that automatically |
@carlinmack These queries was handled in this PR because it has JS code, and It is only in the base.html file |
The goal here is to make sure that all SPARQL queries that were originally contained in .html pages have been moved to .sparql files and those .sparql files are called appropriately, as per #1267 .
The text was updated successfully, but these errors were encountered: