Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that all SPARQL queries have been converted to externalized query format #1284

Closed
Daniel-Mietchen opened this issue Nov 23, 2020 · 7 comments
Assignees
Labels
monadical options suggested for Monadical SPARQL the way Scholia queries Wikidata
Milestone

Comments

@Daniel-Mietchen
Copy link
Member

Daniel-Mietchen commented Nov 23, 2020

The goal here is to make sure that all SPARQL queries that were originally contained in .html pages have been moved to .sparql files and those .sparql files are called appropriately, as per #1267 .

@Daniel-Mietchen Daniel-Mietchen added this to the 30 November 2020 milestone Nov 23, 2020
@Daniel-Mietchen Daniel-Mietchen added the SPARQL the way Scholia queries Wikidata label Nov 23, 2020
@Daniel-Mietchen
Copy link
Member Author

Also check for queries that are commented out, as per #1170 .

@Daniel-Mietchen
Copy link
Member Author

Another thing to check here is that all queries have a proper HTML section ID, as per #1093 .

@carlinmack
Copy link
Collaborator

With the above merged PRs, @curibe can this be closed?

@fnielsen
Copy link
Collaborator

fnielsen commented Jul 29, 2021

I suppose. Do we have a "grep" that can check?

@carlinmack
Copy link
Collaborator

Not sure if this is thorough but:

/scholia/scholia/app/templates$ grep SELECT *.html
base.html:    SELECT DISTINCT ?aspect
base.html:    SELECT DISTINCT ?aspectsubpage

@carlinmack
Copy link
Collaborator

carlinmack commented Jul 29, 2021

In the sidebar, click "Unpin issue" 👍 I thought it would do that automatically

@curibe
Copy link
Collaborator

curibe commented Jul 29, 2021

Not sure if this is thorough but:

/scholia/scholia/app/templates$ grep SELECT *.html
base.html:    SELECT DISTINCT ?aspect
base.html:    SELECT DISTINCT ?aspectsubpage

@carlinmack These queries was handled in this PR because it has JS code, and It is only in the base.html file

@Daniel-Mietchen Daniel-Mietchen unpinned this issue Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monadical options suggested for Monadical SPARQL the way Scholia queries Wikidata
Projects
None yet
Development

No branches or pull requests

6 participants