-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Integration with official LFG Tool #323
Comments
So then, i think its a little overkill to have a whole tab to display the results from the LFG Tool.
|
related issues: |
I originally went with the separate tab for couple reasons. One is that classic didn’t have the tool so it was going to be difficult to have wotlk features and classic being separate but in the same tab. Second reason is I think it had to do with keeping it sorted. The lfg tool posts dont really change so most of the time they would always end up at the bottom and basically hidden. Also performance |
Btw there is a max limit on the results the lfg api returns, think it’s 100 if I remember. One other gotcha is the user can change the category in the tool itself and that would change the results, so just need to handle the case and update the tab accordingly Last thing is the api is a little confusing, if I am remembering correctly it requires a hardware event to fetch any new listings but without it just updates the status of groups it previously returned. Hence why I also added it to update the list when the user opens the addon |
Which integration are you talking in TBC? I don’t recall adding one in TBC but I also forgot that I didn’t upload it until TBC |
yup, i already accounted for pretty much all of this. |
TBC had a group finder that was also used in early WOTLK. I was just calling it the TBC group finder. Later in WOTLK classic they updated to the one thats still used up till Cata |
With patch 1.15.5, blizzard has added a version of the
LFGList
UI for classic wow game modes (currently only on SoD/Anniversary Realms).This addon used to have minor support for the LFG tool back in burning crusade before Vysci forked it for wrath, but it has since been abandoned since blizzard swapped API's/Frames for the LFG Tool sometime in early Wotlk Classic.
It would be nice to re-implement the integration of the
LFGList
tool, there are however some limitations to the new API that make it really cumbersome to work with.Most notably, the GetSearchResultInfo APIs result struct contains "protected strings" which are encrypted strings that only the game client can decrypt. Critically, these types of strings are used for the
name
andcomment
fields:name
- the posting title required when creating a group on the LFG tool (not used in the Era version of the tool)comment
- the optional message/comment you can use when creating a group in the LFG toolAdditionally, we can only query the API for one category at a time (categories being Dungeons, Raids, Quests, Custom, PvP).
These 2 limitations mean that we can only ever display (on the bulletin board) the
LFGList
tool results for a SINGLE category at a time.The text was updated successfully, but these errors were encountered: