Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add world tour section to raids #256

Closed
reetarded opened this issue Jun 25, 2024 · 3 comments · Fixed by #257
Closed

Add world tour section to raids #256

reetarded opened this issue Jun 25, 2024 · 3 comments · Fixed by #257
Labels
enhancement New feature or request

Comments

@reetarded
Copy link

Describe the solution you'd like
A section for the raids in cataclysm that is just "world tour" under the raids section. Many raids advertise their runs as world tours and they are missed. Also expand throne of the four winds keywords since I was missing 50% of them with the default words. My current one is "totfw toftw tofw four winds tofw10 towf25 to4w throne tot4w"

@reetarded reetarded added the enhancement New feature or request label Jun 25, 2024
@juemrami
Copy link
Collaborator

juemrami commented Jun 25, 2024

Hey,

Regarding a "World Tour" category, check out the curseforge alpha/beta. v3.32-alpha3 has support for custom filters and you could make one for world tour.

Planning on officially releasing once i see its stable for the people running the alpha/beta
image

ATM there is no support for complicated search patterns (ie anything more than single words). So you cant match exactly for "world tour" only either "world" or "tour" (see #32). Id opt out of using "world" since it would be matching any post with the word "world" in it (pretty ambiguous)

As for Totfw, ill update the tags, thank you.
Because of the mentioned search pattern limitation i purposefully didnt include "throne" because it would be ambiguous with "Throne of the Tides" for example, and result in false categorizations on the bulletin board.

@juemrami juemrami linked a pull request Jun 27, 2024 that will close this issue
@reetarded
Copy link
Author

Yeah I agree "throne" might be used for the H dungeon, but from my experience I have never seen someone advertise the throne dungeon in LFG chat, every time it is for the raid. People just use rdf for their dungeon grouping.

@juemrami
Copy link
Collaborator

juemrami commented Jul 1, 2024

yea that just a relic of this addon supporting the pre-rdf days.
When i added support for cata, it would have been weird not to include the dungeons.
I think you should keep "throne" as a custom one for now. Whenever sequence pattern matching is implemented i can see about using less ambiguous patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants