[feat][hotfix]: Improved compatibility with LibDBIcon-1.0 minimap buttons
#302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juemrami
commented
Aug 20, 2024
Comment on lines
34
to
+39
| if button.Lib_GPI_MinimapButton.db.lockDistance then | ||
| dist=1 | ||
| button.Lib_GPI_MinimapButton.db.distance = 1 -- locked the perimeter of minimap | ||
| else | ||
| if dist<1 then dist=1 elseif dist>2 then dist=2 end | ||
| local radius = (Minimap:GetWidth() / 2) + 5; | ||
| local dist = math.sqrt(dx*dx+dy*dy) / radius | ||
| button.Lib_GPI_MinimapButton.db.distance = Clamp(dist, 1, 2) -- clamp the distance ratio between 1 and 2 |
There was a problem hiding this comment.
moved this math into the conditional to only be used when necessary (onUpdate functions run every frame)
juemrami
commented
Aug 20, 2024
Comment on lines
+197
to
+201
| if MinimapButton.isUsingLibDBIcon then --[[position updates handled by LibDBIcon]] return end; | ||
|
|
||
| local radiusOffset = LibDBIcon and LibDBIcon.radius or 10 -- better align with any LibDBIcons. |
There was a problem hiding this comment.
if LibDBIcon is available and the user is not using it to manage the minimap button, then we should still try to match thier radius value to better align. Otherwise we can fallback to 10 (resulting in the button sitting on the edge instead of through it)
There was a problem hiding this comment.
Before (slightly higher than LibDBIcons):
After (inline):
juemrami
force-pushed
the
08-19-_hotfix_positioning_tweaks_for_the_minimap_button
branch
from
4f8e394 to
8fbdb72
Compare
…uttons - adds a `UseLibDBIcon` option available when the user has `LibDBIcon-1.0` installed which lets LibDBIcon handle the minimap button. - disabled by default, unless the user currently has the `lockDistance`` option enabled which attaches the minimap button to the minimap. -  - Better aligns our minimap button with LibDBIcon-1.0 buttons if any exist. - Minimap button can no longer be dragged off the right side of the screen when not anchored to the Minimap.
juemrami
force-pushed
the
08-19-_hotfix_positioning_tweaks_for_the_minimap_button
branch
from
8fbdb72 to
0ab7450
Compare
juemrami
deleted the
08-19-_hotfix_positioning_tweaks_for_the_minimap_button
branch
This was referenced Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues:
In this PR
UseLibDBIconoption as "Manage minimap button using LibDBIcon".LibDBIcon-1.0installed.lockDistance) option, which attaches the button to the edge of minimap when enabled.UseLibDBIconis not enabled).LibDBIcon-1.0, it cannot be dragged away from the edge of the minimap at all."Lib_GPI_Minimap_"..TOCNAMEtoTOCNAME.."MinimapButton"Images: