From 09d217a5e257c515e6aa9be514e3cd93e88af2f5 Mon Sep 17 00:00:00 2001
From: reduckted <reduckted@outlook.com>
Date: Thu, 16 Feb 2023 20:48:34 +1000
Subject: [PATCH 1/4] FrameShow is not flagged.

---
 .../Windows/WindowFrame.cs                                     | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/toolkit/Community.VisualStudio.Toolkit.Shared/Windows/WindowFrame.cs b/src/toolkit/Community.VisualStudio.Toolkit.Shared/Windows/WindowFrame.cs
index df0af42..649557f 100644
--- a/src/toolkit/Community.VisualStudio.Toolkit.Shared/Windows/WindowFrame.cs
+++ b/src/toolkit/Community.VisualStudio.Toolkit.Shared/Windows/WindowFrame.cs
@@ -1,4 +1,4 @@
-// ================================================================================================
+// ================================================================================================
 // WindowFrame.cs
 //
 // Created: 2008.07.02, by Istvan Novak (DeepDiver)
@@ -440,7 +440,6 @@ public enum FramePosition
     /// <summary>
     /// Specifies options when the show state of a window frame changes.
     /// </summary>
-    [Flags]
     public enum FrameShow
     {
         /// <summary>Reason unknown</summary>

From a6ae3f79d76cfd24c3846f19c41f341c1c14d6c4 Mon Sep 17 00:00:00 2001
From: reduckted <reduckted@outlook.com>
Date: Thu, 16 Feb 2023 20:51:19 +1000
Subject: [PATCH 2/4] Removed duplicate and obsolete enum values from
 FrameShow.

---
 .../Windows/WindowFrame.cs                                  | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/toolkit/Community.VisualStudio.Toolkit.Shared/Windows/WindowFrame.cs b/src/toolkit/Community.VisualStudio.Toolkit.Shared/Windows/WindowFrame.cs
index 649557f..804692a 100644
--- a/src/toolkit/Community.VisualStudio.Toolkit.Shared/Windows/WindowFrame.cs
+++ b/src/toolkit/Community.VisualStudio.Toolkit.Shared/Windows/WindowFrame.cs
@@ -442,12 +442,8 @@ public enum FramePosition
     /// </summary>
     public enum FrameShow
     {
-        /// <summary>Reason unknown</summary>
-        Unknown = 0,
-        /// <summary>Obsolete; use WinHidden.</summary>
-        Hidden = __FRAMESHOW.FRAMESHOW_Hidden,
         /// <summary>Window (tabbed or otherwise) is hidden.</summary>
-        WinHidden = __FRAMESHOW.FRAMESHOW_WinHidden,
+        Hidden = __FRAMESHOW.FRAMESHOW_WinHidden,
         /// <summary>A nontabbed window is made visible.</summary>
         Shown = __FRAMESHOW.FRAMESHOW_WinShown,
         /// <summary>A tabbed window is activated (made visible).</summary>

From b8b3d10d4bcb55e7345e3597589a6029aa38b097 Mon Sep 17 00:00:00 2001
From: reduckted <reduckted@outlook.com>
Date: Thu, 16 Feb 2023 20:52:03 +1000
Subject: [PATCH 3/4] Added comments explaining what the equivalent __SHOWFRAME
 enum value is.

---
 .../Windows/WindowFrame.cs                    | 47 +++++++++++++++----
 1 file changed, 37 insertions(+), 10 deletions(-)

diff --git a/src/toolkit/Community.VisualStudio.Toolkit.Shared/Windows/WindowFrame.cs b/src/toolkit/Community.VisualStudio.Toolkit.Shared/Windows/WindowFrame.cs
index 804692a..9ea41c8 100644
--- a/src/toolkit/Community.VisualStudio.Toolkit.Shared/Windows/WindowFrame.cs
+++ b/src/toolkit/Community.VisualStudio.Toolkit.Shared/Windows/WindowFrame.cs
@@ -232,7 +232,7 @@ public async Task<bool> IsOnScreenAsync()
         public async Task<DocumentView?> GetDocumentViewAsync()
         {
             await ThreadHelper.JoinableTaskFactory.SwitchToMainThreadAsync();
-           
+
             // Force the loading of a document that may be pending initialization.
             // See https://docs.microsoft.com/en-us/visualstudio/extensibility/internals/delayed-document-loading
             _frame.GetProperty((int)__VSFPROPID.VSFPROPID_DocView, out _);
@@ -442,23 +442,50 @@ public enum FramePosition
     /// </summary>
     public enum FrameShow
     {
-        /// <summary>Window (tabbed or otherwise) is hidden.</summary>
+        /// <summary>
+        /// <para>Window (tabbed or otherwise) is hidden.</para>
+        /// <para>Equivalent to <see cref="__FRAMESHOW.FRAMESHOW_WinHidden"/>.</para>
+        /// </summary>
         Hidden = __FRAMESHOW.FRAMESHOW_WinHidden,
-        /// <summary>A nontabbed window is made visible.</summary>
+        /// <summary>
+        /// <para>A non-tabbed window is made visible.</para>
+        /// <para>Equivalent to <see cref="__FRAMESHOW.FRAMESHOW_WinShown"/>.</para>
+        /// </summary>
         Shown = __FRAMESHOW.FRAMESHOW_WinShown,
-        /// <summary>A tabbed window is activated (made visible).</summary>
+        /// <summary>
+        /// <para>A tabbed window is activated (made visible).</para>
+        /// <para>Equivalent to <see cref="__FRAMESHOW.FRAMESHOW_TabActivated"/>.</para>
+        /// </summary>
         TabActivated = __FRAMESHOW.FRAMESHOW_TabActivated,
-        /// <summary>A tabbed window is deactivated.</summary>
+        /// <summary>
+        /// <para>A tabbed window is deactivated.</para>
+        /// <para>Equivalent to <see cref="__FRAMESHOW.FRAMESHOW_TabDeactivated"/>.</para>
+        /// </summary>
         TabDeactivated = __FRAMESHOW.FRAMESHOW_TabDeactivated,
-        /// <summary>Window is restored to normal state.</summary>
+        /// <summary>
+        /// <para>Window is restored to normal state.</para>
+        /// <para>Equivalent to <see cref="__FRAMESHOW.FRAMESHOW_WinRestored"/>.</para>
+        /// </summary>
         Restored = __FRAMESHOW.FRAMESHOW_WinRestored,
-        /// <summary>Window is minimized.</summary>
+        /// <summary>
+        /// <para>Window is minimized.</para>
+        /// <para>Equivalent to <see cref="__FRAMESHOW.FRAMESHOW_WinMinimized"/>.</para>
+        /// </summary>
         Minimized = __FRAMESHOW.FRAMESHOW_WinMinimized,
-        /// <summary>Window is maximized.</summary>
+        /// <summary>
+        /// <para>Window is maximized.</para>
+        /// <para>Equivalent to <see cref="__FRAMESHOW.FRAMESHOW_WinMaximized"/>.</para>
+        /// </summary>
         Maximized = __FRAMESHOW.FRAMESHOW_WinMaximized,
-        /// <summary>Multi-instance tool window destroyed.</summary>
+        /// <summary>
+        /// <para>Multi-instance tool window destroyed.</para>
+        /// <para>Equivalent to <see cref="__FRAMESHOW.FRAMESHOW_DestroyMultInst"/>.</para>
+        /// </summary>
         DestroyMultipleInstance = __FRAMESHOW.FRAMESHOW_DestroyMultInst,
-        /// <summary>Autohidden window is about to slide into view.</summary>
+        /// <summary>
+        /// <para>Auto-hidden window is about to slide into view.</para>
+        /// <para>Equivalent to <see cref="__FRAMESHOW.FRAMESHOW_AutoHideSlideBegin"/>.</para>
+        /// </summary>
         AutoHideSlideBegin = __FRAMESHOW.FRAMESHOW_AutoHideSlideBegin
     }
 

From 4e04081ff8ff84b8a545ec8b5e19c9aad8f15dc2 Mon Sep 17 00:00:00 2001
From: reduckted <reduckted@outlook.com>
Date: Thu, 16 Feb 2023 21:03:56 +1000
Subject: [PATCH 4/4] Extended FrameShow enum to include values from
 __FRAMESHOW2, __FRAMESHOW3 and __FRAMESHOW4.

---
 .../Windows/WindowFrame.cs                    | 48 ++++++++++++++++++-
 1 file changed, 46 insertions(+), 2 deletions(-)

diff --git a/src/toolkit/Community.VisualStudio.Toolkit.Shared/Windows/WindowFrame.cs b/src/toolkit/Community.VisualStudio.Toolkit.Shared/Windows/WindowFrame.cs
index 9ea41c8..3cc5b18 100644
--- a/src/toolkit/Community.VisualStudio.Toolkit.Shared/Windows/WindowFrame.cs
+++ b/src/toolkit/Community.VisualStudio.Toolkit.Shared/Windows/WindowFrame.cs
@@ -1,4 +1,4 @@
-// ================================================================================================
+// ================================================================================================
 // WindowFrame.cs
 //
 // Created: 2008.07.02, by Istvan Novak (DeepDiver)
@@ -440,6 +440,13 @@ public enum FramePosition
     /// <summary>
     /// Specifies options when the show state of a window frame changes.
     /// </summary>
+    /// <remarks>
+    /// This combines the values from 
+    /// <see cref="__FRAMESHOW"/>, 
+    /// <see cref="__FRAMESHOW2"/>, 
+    /// <see cref="__FRAMESHOW3"/> and 
+    /// <see cref="__FRAMESHOW4"/>.
+    /// </remarks>
     public enum FrameShow
     {
         /// <summary>
@@ -486,7 +493,32 @@ public enum FrameShow
         /// <para>Auto-hidden window is about to slide into view.</para>
         /// <para>Equivalent to <see cref="__FRAMESHOW.FRAMESHOW_AutoHideSlideBegin"/>.</para>
         /// </summary>
-        AutoHideSlideBegin = __FRAMESHOW.FRAMESHOW_AutoHideSlideBegin
+        AutoHideSlideBegin = __FRAMESHOW.FRAMESHOW_AutoHideSlideBegin,
+        /// <summary>
+        /// <para>A window is about to be hidden.</para>
+        /// <para>Equivalent to <see cref="__FRAMESHOW2.FRAMESHOW_BeforeWinHidden"/>.</para>
+        /// </summary>
+        BeforeHidden = __FRAMESHOW2.FRAMESHOW_BeforeWinHidden,
+        /// <summary>
+        /// <para>Auto-hidden window is finished sliding into view.</para>
+        /// <para>Equivalent to <see cref="__FRAMESHOW2.FRAMESHOW_AutoHideSlideEnd"/>.</para>
+        /// </summary>
+        AutoHideSlideEnd = __FRAMESHOW2.FRAMESHOW_AutoHideSlideEnd,
+        /// <summary>
+        /// <para>A window is activated (made visible).</para>
+        /// <para>Equivalent to <see cref="__FRAMESHOW3.FRAMESHOW_WinActivated"/>.</para>
+        /// </summary>
+        Activated = __FRAMESHOW3.FRAMESHOW_WinActivated,
+        /// <summary>
+        /// <para>The window's inner content received keyboard focus.</para>
+        /// <para>Equivalent to <see cref="__FRAMESHOW4.FRAMESHOW_WinContentGotFocus"/>.</para>
+        /// </summary>
+        ContentGotFocus = __FRAMESHOW4.FRAMESHOW_WinContentGotFocus,
+        /// <summary>
+        /// <para>The window's inner content lost keyboard focus.</para>
+        /// <para>Equivalent to <see cref="__FRAMESHOW4.FRAMESHOW_WinContentLostFocus"/>.</para>
+        /// </summary>
+        ContentLostFocus = __FRAMESHOW4.FRAMESHOW_WinContentLostFocus
     }
 
     /// <summary>
@@ -573,4 +605,16 @@ public WindowFrameDockChangedEventArgs(Rectangle position, bool docked)
             Docked = docked;
         }
     }
+
+
+#if VS14
+    /// <summary>
+    /// __FRAMESHOW4 was first defined in Visual Studio 15.
+    /// </summary>
+    internal enum __FRAMESHOW4
+    {
+        FRAMESHOW_WinContentGotFocus = 13,
+        FRAMESHOW_WinContentLostFocus
+    }
+#endif
 }
\ No newline at end of file